build(docs-infra): examples should not run ngcc for all formats (angular#28984)

devversion · AndrewKushnir · commit 587424749437 · 2019-02-28T10:46:12.000-08:00
Currently when adding the example boilerplate to all examples with Ivy enabled, we run Ngcc and transform all found formats. This potentially slows down the build and is not necessary as we only need the "fesm5" and "fesm2015" bundles. PR Close angular#28984
diff --git a/aio/tools/examples/example-boilerplate.js b/aio/tools/examples/example-boilerplate.js
@@ -104,7 +104,12 @@ class ExampleBoilerPlate {
     }
 
     if (ivy) {
-      shelljs.exec(`yarn --cwd ${SHARED_PATH} ivy-ngcc`);
+      // We only need the "fesm5" bundles as the CLI webpack build does not need
+      // any other formats for building and serving. Ngcc currently only updates
+      // the module typings if we specified an "es2015" format. This means that
+      // we also need to build with "fesm2015" in order to get updated typings
+      // which are needed for compilation.
+      shelljs.exec(`yarn --cwd ${SHARED_PATH} ivy-ngcc --formats fesm2015 fesm5`);
     }
 
     exampleFolders.forEach(exampleFolder => {

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,12 @@ class ExampleBoilerPlate {`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`if (ivy) {`
`107`		- shelljs.exec(`yarn --cwd ${SHARED_PATH} ivy-ngcc`);
	`107`	`+ // We only need the "fesm5" bundles as the CLI webpack build does not need`
	`108`	`+ // any other formats for building and serving. Ngcc currently only updates`
	`109`	`+ // the module typings if we specified an "es2015" format. This means that`
	`110`	`+ // we also need to build with "fesm2015" in order to get updated typings`
	`111`	`+ // which are needed for compilation.`
	`112`	+ shelljs.exec(`yarn --cwd ${SHARED_PATH} ivy-ngcc --formats fesm2015 fesm5`);
`108`	`113`	`}`
`109`	`114`
`110`	`115`	`exampleFolders.forEach(exampleFolder => {`