Skip to content

Commit aadc332

Browse files
devversionmhevery
authored andcommitted
build: run tree benchmark tests with bazel (angular#28568)
PR Close angular#28568
1 parent c916b36 commit aadc332

22 files changed

+220
-312
lines changed

modules/benchmarks/benchmark_test.bzl

+24
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
load("//packages/bazel:index.bzl", "protractor_web_test_suite")
2+
3+
"""
4+
Macro that can be used to define a benchmark test. This differentiates from
5+
a normal Protractor test suite because we specify a custom "perf" configuration
6+
that sets up "@angular/benchpress".
7+
"""
8+
9+
def benchmark_test(name, server, deps, tags = []):
10+
protractor_web_test_suite(
11+
name = name,
12+
configuration = "//:protractor-perf.conf.js",
13+
data = [
14+
"//packages/bazel/src/protractor/utils",
15+
"//packages/benchpress",
16+
],
17+
on_prepare = "//modules/benchmarks:start-server.js",
18+
server = server,
19+
tags = tags,
20+
deps = [
21+
"@ngdeps//protractor",
22+
"@ngdeps//yargs",
23+
] + deps,
24+
)

modules/benchmarks/e2e_test/tree_data.ts

-79
This file was deleted.

modules/benchmarks/e2e_test/tree_perf.ts

-93
This file was deleted.

modules/benchmarks/e2e_test/tree_spec.ts

-63
This file was deleted.

modules/benchmarks/src/BUILD.bazel

+1-7
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,7 @@ load("//tools:defaults.bzl", "ts_library")
44

55
ts_library(
66
name = "util_lib",
7-
srcs = [
8-
"util.ts",
9-
],
10-
deps = [
11-
"//packages:types",
12-
"//packages/core",
13-
],
7+
srcs = ["util.ts"],
148
)
159

1610
ts_library(

modules/benchmarks/src/tree/BUILD.bazel

+21-10
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,36 @@ load("//tools:defaults.bzl", "ts_library")
44

55
ts_library(
66
name = "util_lib",
7-
srcs = [
8-
"util.ts",
9-
],
7+
srcs = ["util.ts"],
8+
deps = ["//modules/benchmarks/src:util_lib"],
9+
)
10+
11+
ts_library(
12+
name = "test_utils_lib",
13+
testonly = 1,
14+
srcs = ["tree_perf_test_utils.ts"],
1015
deps = [
11-
"//modules/benchmarks/src:util_lib",
12-
"//packages:types",
13-
"//packages/core",
16+
"//modules/e2e_util",
17+
"@ngdeps//protractor",
1418
],
1519
)
1620

1721
ts_library(
1822
name = "perf_lib",
1923
testonly = 1,
20-
srcs = [
21-
"tree_perf.spec.ts",
24+
srcs = ["tree_perf.spec.ts"],
25+
deps = [
26+
":test_utils_lib",
27+
"@ngdeps//protractor",
2228
],
29+
)
30+
31+
ts_library(
32+
name = "perf_detect_changes_lib",
33+
testonly = 1,
34+
srcs = ["tree_perf_detect_changes.spec.ts"],
2335
deps = [
24-
"//modules/e2e_util",
25-
"//packages:types",
36+
":test_utils_lib",
2637
"@ngdeps//protractor",
2738
],
2839
)

modules/benchmarks/src/tree/baseline/BUILD.bazel

+7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
load("//tools:defaults.bzl", "ts_library")
22
load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
3+
load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
34

45
package(default_visibility = ["//modules/benchmarks:__subpackages__"])
56

@@ -20,3 +21,9 @@ ts_devserver(
2021
port = 4200,
2122
deps = [":baseline"],
2223
)
24+
25+
benchmark_test(
26+
name = "perf",
27+
server = ":devserver",
28+
deps = ["//modules/benchmarks/src/tree:perf_lib"],
29+
)

modules/benchmarks/src/tree/incremental_dom/BUILD.bazel

+7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
load("//tools:defaults.bzl", "ts_library")
22
load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
3+
load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
34

45
package(default_visibility = ["//modules/benchmarks:__subpackages__"])
56

@@ -24,3 +25,9 @@ ts_devserver(
2425
],
2526
deps = [":incremental_dom"],
2627
)
28+
29+
benchmark_test(
30+
name = "perf",
31+
server = ":devserver",
32+
deps = ["//modules/benchmarks/src/tree:perf_lib"],
33+
)

modules/benchmarks/src/tree/iv/BUILD.bazel

+10
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
2+
load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
23

34
package(default_visibility = ["//modules/benchmarks:__subpackages__"])
45

@@ -8,3 +9,12 @@ ts_devserver(
89
port = 4200,
910
static_files = ["tree.js"],
1011
)
12+
13+
benchmark_test(
14+
name = "perf",
15+
server = ":devserver",
16+
deps = [
17+
"//modules/benchmarks/src/tree:perf_detect_changes_lib",
18+
"//modules/benchmarks/src/tree:perf_lib",
19+
],
20+
)

modules/benchmarks/src/tree/ng1/BUILD.bazel

+10
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
load("//tools:defaults.bzl", "ts_library")
22
load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
3+
load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
34

45
package(default_visibility = ["//modules/benchmarks:__subpackages__"])
56

@@ -23,3 +24,12 @@ ts_devserver(
2324
],
2425
deps = [":ng1"],
2526
)
27+
28+
benchmark_test(
29+
name = "perf",
30+
server = ":devserver",
31+
deps = [
32+
"//modules/benchmarks/src/tree:perf_detect_changes_lib",
33+
"//modules/benchmarks/src/tree:perf_lib",
34+
],
35+
)

0 commit comments

Comments
 (0)