Skip to content

Commit b7c17ff

Browse files
devversionkara
authored andcommitted
ci: run legacy saucelabs for every build (angular#29255)
Recently we moved the Saucelabs job into a cronjob in order to avoid heavy flakiness that we experienced due to a Saucelabs connect bug that has been supposedly fixed by the Saucelabs team (no new version is released yet though). Our initial assumption was that we very rarely hit specific browser failures and can therefore move the Saucelabs tests into a cronjob, but after some days of having the cronjob, we realized that we actually hit browser-specific failures quite often and that we should run the tests for every PR (like before) PR Close angular#29255
1 parent c5daaa9 commit b7c17ff

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

.circleci/config.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ jobs:
209209
path: dist/bin/packages/core/test/bundling/todo/bundle.min.js.br
210210
destination: core/todo/bundle.br
211211

212-
test_saucelabs:
212+
test_saucelabs_bazel:
213213
<<: *job_defaults
214214
# In order to avoid the bottleneck of having a slow host machine, we acquire a better
215215
# container for this job. This is necessary because we launch a lot of browsers concurrently
@@ -587,6 +587,9 @@ workflows:
587587
- test_aio:
588588
requires:
589589
- setup
590+
- legacy-unit-tests-saucelabs:
591+
requires:
592+
- setup
590593
- deploy_aio:
591594
requires:
592595
- test_aio
@@ -640,6 +643,7 @@ workflows:
640643
# since the publishing script expects the legacy outputs layout.
641644
- build-npm-packages
642645
- build-ivy-npm-packages
646+
- legacy-unit-tests-saucelabs
643647
- legacy-misc-tests
644648
- material-unit-tests:
645649
requires:
@@ -648,14 +652,9 @@ workflows:
648652
saucelabs_tests:
649653
jobs:
650654
- setup
651-
- test_saucelabs:
655+
- test_saucelabs_bazel:
652656
requires:
653657
- setup
654-
- legacy-unit-tests-saucelabs:
655-
# Don't open up multiple saucelabs tunnels at the same
656-
# time to minimize flakes
657-
requires:
658-
- test_saucelabs
659658
triggers:
660659
- schedule:
661660
# Runs the Saucelabs legacy tests every hour. We still want to run Saucelabs

0 commit comments

Comments
 (0)