Skip to content

Commit 5880c23

Browse files
committed
7a39165 fix(DomRenderer): correctly handle namespaced attributes
1 parent 525e995 commit 5880c23

File tree

59 files changed

+243
-62
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+243
-62
lines changed

BUILD_INFO

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
Wed Feb 17 19:24:33 UTC 2016
2-
9e88d4e57fb5d18a62073ac4ef059eb18beda726
1+
Wed Feb 17 19:38:28 UTC 2016
2+
7a3916536ca2e66acb357b772f5ca0f08555c878

lib/platform/browser.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
library angular2.platform.browser;
22

3+
import "dart:async";
34
export "package:angular2/src/core/angular_entrypoint.dart"
45
show AngularEntrypoint;
56
export "package:angular2/src/platform/browser_common.dart"

lib/platform/browser_static.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
library angular2.platform.browser_static;
22

3+
import "dart:async";
34
export "package:angular2/src/core/angular_entrypoint.dart"
45
show AngularEntrypoint;
56
export "package:angular2/src/platform/browser_common.dart"

lib/src/common/forms/directives/radio_control_value_accessor.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,8 @@ class RadioControlValueAccessor
9393
Injector _injector;
9494
RadioButtonState _state;
9595
NgControl _control;
96-
@Input() String name;
96+
@Input()
97+
String name;
9798
Function _fn;
9899
var onChange = () {};
99100
var onTouched = () {};

lib/src/common/pipes/async_pipe.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
library angular2.src.common.pipes.async_pipe;
22

3+
import "dart:async";
34
import "package:angular2/src/facade/lang.dart"
45
show isBlank, isPresent, isPromise;
56
import "package:angular2/src/facade/async.dart"

lib/src/compiler/html_parser.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import "package:angular2/src/core/di.dart" show Injectable;
1515
import "html_lexer.dart" show HtmlToken, HtmlTokenType, tokenizeHtml;
1616
import "parse_util.dart" show ParseError, ParseLocation, ParseSourceSpan;
1717
import "html_tags.dart"
18-
show HtmlTagDefinition, getHtmlTagDefinition, getNsPrefix;
18+
show HtmlTagDefinition, getHtmlTagDefinition, getNsPrefix, mergeNsAndName;
1919

2020
class HtmlTreeError extends ParseError {
2121
String elementName;
@@ -252,10 +252,6 @@ class TreeBuilder {
252252
}
253253
}
254254

255-
String mergeNsAndName(String prefix, String localName) {
256-
return isPresent(prefix) ? '''@${ prefix}:${ localName}''' : localName;
257-
}
258-
259255
String getElementFullName(
260256
String prefix, String localName, HtmlElementAst parentElement) {
261257
if (isBlank(prefix)) {

lib/src/compiler/html_tags.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -417,3 +417,7 @@ List<String> splitNsName(String elementName) {
417417
String getNsPrefix(String elementName) {
418418
return splitNsName(elementName)[0];
419419
}
420+
421+
String mergeNsAndName(String prefix, String localName) {
422+
return isPresent(prefix) ? '''@${ prefix}:${ localName}''' : localName;
423+
}

lib/src/compiler/runtime_compiler.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
library angular2.src.compiler.runtime_compiler;
22

3+
import "dart:async";
34
import "package:angular2/src/core/linker/compiler.dart"
45
show Compiler, Compiler_;
56
import "package:angular2/src/core/linker/view_ref.dart"

lib/src/compiler/style_compiler.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
library angular2.src.compiler.style_compiler;
22

3+
import "dart:async";
34
import "directive_metadata.dart"
45
show CompileTypeMetadata, CompileTemplateMetadata;
56
import "source_module.dart" show SourceModule, SourceExpression, moduleRef;

lib/src/compiler/template_compiler.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
library angular2.src.compiler.template_compiler;
22

3+
import "dart:async";
34
import "package:angular2/src/facade/lang.dart"
45
show IS_DART, Type, Json, isBlank, isPresent, stringify, evalExpression;
56
import "package:angular2/src/facade/exceptions.dart" show BaseException;

0 commit comments

Comments
 (0)