Skip to content

Wait for state publication in SLMFileSettingsIT.testSettingsApplied #130869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nielsbauman
Copy link
Contributor

Since the cluster state API no longer runs on the master node, we need to wait for the cluster state publication to have finished before retrieving the cluster state.

Fixes #130853

Since the cluster state API no longer runs on the master node, we need
to wait for the cluster state publication to have finished before
retrieving the cluster state.

Fixes elastic#130853
@nielsbauman nielsbauman requested a review from masseyke July 8, 2025 22:34
@nielsbauman nielsbauman added >test Issues or PRs that are addressing/adding tests :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Jul 8, 2025
@elasticsearchmachine elasticsearchmachine added v9.2.0 Team:Data Management Meta label for data/management team labels Jul 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not very familiar with this test though. Do we need the same awaitMasterNode() call in assertClusterStateNotSaved()? And is the call to awaitMasterNode() for a single node just before calling assertClusterStateSaveOK() now redundant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] SLMFileSettingsIT testSettingsApplied failing
3 participants