Fix Vyper detection in EtherscanVerifier & Convert FileManager to async/await #5837
+107
−263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for remixproject pending review.Visit the deploys page to approve it
|
manuelwedler
suggested changes
Mar 28, 2025
Comment on lines
47
to
+48
| const metadata = JSON.parse(compilerAbstract.data.contracts[submittedContract.filePath][submittedContract.contractName].metadata) | ||
| const language = metadata?.compiler?.language?.toLowerCase() || 'solidity' |
There was a problem hiding this comment.
Vyper does not have metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses Vyper contract detection within
EtherscanVerifierby replacing the TODO comment with actual logic to handle Vyper compiler versions. It also refactors theFileManagerfrom callback-based methods to fully async/await, removing the need for the old TODO comments and improving clarity. Key updates:EtherscanVerifier :
Detects Vyper by checking
metadata.compiler.language; appendsvyper-to the version where appropriate.FileManager:
Uses async/await in all file operations (
readFile,setFileContent, etc.), removing outdated callback patterns and old TODO notes.