Add msgpush. #1
Merged
Add msgpush. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfireman
requested changes
Aug 8, 2018
| if (WINDOW_SIZE>0) { | ||
| buffer = new byte[WINDOW_SIZE][MSG_SIZE]; | ||
| } | ||
| try { |
There was a problem hiding this comment.
Could you please remove SLEEP_TIME_MS?
| private static final boolean USE_GCI = Boolean.parseBoolean(System.getenv("USE_GCI")); | ||
| private static int MSG_SIZE; | ||
| private static int WINDOW_SIZE; | ||
| private static int COMPUTING_TIME_MS = 15; |
There was a problem hiding this comment.
Could you please remove COMPUTING_TIME_MS? It is not being used.
| buffer[msgCount++ % WINDOW_SIZE] = byteArray; | ||
| } | ||
|
|
||
| long max = 5000; |
danielfireman
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It brings the msgpush from java-experiments.