Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clerk employee here 👋 While updating the Clerk docs' Convex integration guide (PR), I noticed this guide could use some love. From the Clerk Docs team to yours 💜
Notes about the changes:
Tanstack Start
section. This may get moved to the top again pending on your feedback about this next point:Next.js
section, which bloats the page, and I think could get moved to https://docs.convex.dev/client/react/nextjs/with-clerk similar to how you do it for Tanstack Start. Let me know what you think and I can update the PR because I have an idea of how to reorganize this guide once thatNext.js
section is moved.React
andNext.js
sections. I removed them as "supplemental" (at the bottom of the guide) sections because they are already included in the React/Next.js set ups, and its repetitive information. Plus, the guide now mentions to users to use theReact
setup guide if their guide isn't listed. So if they're using Expo, or any other React-based SDK, this information is still available on the page for them.Lastly, there are some TODO's. And there are code examples that you may want in your
<TSAndJSSnippet>
component. Let me know what you think - these are heavy changes, so please feel free to even set up a call and tackle it together :) I love good docs, and want anything Clerk-related to be top notch 😻💜Cheers 😸💖
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.