Improve warnings to call out if change matches consensus

Author: cburgmer

test/Clojure_json-path.yaml

@@ -18,26 +18,31 @@ queries:
     document: ["first", "second", "third"]
     result: "second"
     status: fail
+    consensus: ["second", "third"]
   - id: array_index_slice_only_end
     selector: $[:2]
     document: ["first", "second", "third", "forth", "fifth"]
     result: "third"
     status: fail
+    consensus: ["first", "second"]
   - id: array_index_slice_only_start
     selector: $[1:]
     document: ["first", "second", "third", "forth", "fifth"]
     result: "second"
     status: fail
+    consensus: ["second", "third", "forth", "fifth"]
   - id: array_index_slice_start_end
     selector: $[1:3]
     document: ["first", "second", "third", "forth", "fifth"]
     result: "second"
     status: fail
+    consensus: ["second", "third"]
   - id: array_index_slice_start_end_step
     selector: $[0:3:2]
     document: ["first", "second", "third", "forth", "fifth"]
     result: "first"
     status: fail
+    consensus: ["first", "third"]
   - id: array_index_slice_start_end_step_0
     selector: $[0:3:0]
     document: ["first", "second", "third", "forth", "fifth"]
@@ -48,11 +53,13 @@ queries:
     document: ["first", "second", "third", "forth", "fifth"]
     result: "first"
     status: fail
+    consensus: ["first", "second", "third"]
   - id: array_index_slice_start_end_step_non_aligned
     selector: $[0:4:2]
     document: ["first", "second", "third", "forth", "fifth"]
     result: "first"
     status: fail
+    consensus: ["first", "third"]
   - id: array_index_slice_start_equals_end
     selector: $[0:0]
     document: ["first", "second"]
@@ -63,16 +70,19 @@ queries:
     document: ["first", "second"]
     result: "first"
     status: fail
+    consensus: ["first"]
   - id: array_index_union
     selector: $[0,1]
     document: ["first", "second", "third"]
     result: "first"
     status: fail
+    consensus: ["first", "second"]
   - id: key_bracket_notation_with_star_literal
     selector: $['*']
     document: {"*": "value"}
     result: ["value"]
     status: fail
+    consensus: "value"
   - id: key_dot_notation
     selector: $.key
     document: {"key": "value"}
@@ -123,6 +133,7 @@ queries:
     document: ["string", 42, {"key": "value"}, [0, 1]]
     result: ["string", 42, {"key": "value"}, 0, 1]
     status: fail
+    consensus: ["string", 42, {"key": "value"}, [0, 1]]
   - id: wildcard_bracket_notation_on_null_value_array
     selector: $[*]
     document: [40, null, 42]
@@ -133,13 +144,16 @@ queries:
     document: {"some": "string", "int": 42, "object": {"key": "value"}, "array": [0, 1]}
     result: ["string", 42, {"key": "value"}, 0, 1]
     status: fail
+    consensus: ["string", 42, {"key": "value"}, [0, 1]]
   - id: wildcard_dot_notation_on_array
     selector: $.*
     document: ["string", 42, {"key": "value"}, [0, 1]]
     result: ["string", 42, {"key": "value"}, 0, 1]
     status: fail
+    consensus: ["string", 42, {"key": "value"}, [0, 1]]
   - id: wildcard_dot_notation_on_object
     selector: $.*
     document: {"some": "string", "int": 42, "object": {"key": "value"}, "array": [0, 1]}
     result: ["string", 42, {"key": "value"}, 0, 1]
     status: fail
+    consensus: ["string", 42, {"key": "value"}, [0, 1]]

test/json_path/test/regression_test.clj

@@ -22,13 +22,17 @@
 (deftest warning-on-changes-for-non-conforming-queries-based-on-consensus
   (->> (queries_from_suite "test/Clojure_json-path.yaml")
        (filter (fn [{status :status}] (not= status "pass")))
-       (map (fn [{:keys [selector document result status id]}]
+       (map (fn [{:keys [selector document result status consensus id]}]
               (testing id
                 (let [last-recorded result
                       current (json-path/at-path selector document)]
                   (when (not= last-recorded
                               current)
-                    (println (format "Warning: result has changed for %s: %s (status %s)" id selector status))
-                    (println (format "         was    %s" (pr-str last-recorded)))
-                    (println (format "         now is %s" (pr-str current))))))))
+                    (if (= consensus
+                           current)
+                      (println (format "Result has changed for %s: %s now matching the consensus" id selector))
+                      (do
+                        (println (format "Warning: result has changed for %s: %s (status %s)" id selector status))
+                        (println (format "         was    %s" (pr-str last-recorded)))
+                        (println (format "         now is %s" (pr-str current))))))))))
        doall))