refactoring things

Author: goenning

bkp.txt

@@ -0,0 +1 @@
+

pages/HomePage.ts

@@ -27,7 +27,9 @@ export class HomePage extends Page {
     await this.browser.waitUntilIsVisible(() => this.IdeaTitle);
   }
 
-  public async submitNewIdea(): Promise<void> {
+  public async submitNewIdea(title: string, description: string): Promise<void> {
+    await this.IdeaTitle.sendKeys(title);
+    await this.IdeaDescription.sendKeys(description);
     await this.SubmitIdea.click();
     await this.browser.waitForPage(ShowIdeaPage);
   }

pages/ShowIdeaPage.ts

@@ -8,7 +8,7 @@ export class ShowIdeaPage extends Page {
   @findBy('.idea-header .header')
   public Title: WebElementPromise;
 
-  @findBy('div > span')
+  @findBy('div.description')
   public Description: WebElementPromise;
 
   @findBy('.support-counter .value')

specs/spec.ts

@@ -37,9 +37,7 @@ specification('Users can submit ideas', () => {
 
     when('new idea is submitted', async () => {
       action(async () => {
-        await pages.home.IdeaTitle.sendKeys('Add support to TypeScript');
-        await pages.home.IdeaDescription.sendKeys('Because the language and community is awesome! :)');
-        await pages.home.submitNewIdea();
+        await pages.home.submitNewIdea('Add support to TypeScript', 'Because the language and community is awesome! :)');
       });
 
       then('it should have 1 supporter', async () => {

tests/test.ts

@@ -1,4 +1,5 @@
 import { Browser, ensure } from '../lib';
+import { Builder, ThenableWebDriver, WebElement, By, WebElementPromise, until } from 'selenium-webdriver';
 import { AllPages } from '../pages';
 
 describe('Submit ideas', () => {
@@ -31,9 +32,7 @@ describe('Submit ideas', () => {
     await ensure(pages.home.UserMenu).textIs('Darth Vader');
 
     // Action
-    await pages.home.IdeaTitle.sendKeys('Add support to TypeScript');
-    await pages.home.IdeaDescription.sendKeys('Because the language and community is awesome! :)');
-    await pages.home.submitNewIdea();
+    await pages.home.submitNewIdea('Add support to TypeScript', 'Because the language and community is awesome! :)');
 
     // Assert
     await Promise.all([

tslint.json

@@ -27,7 +27,10 @@
         "no-console": [
             false
         ],
-        "object-literal-shorthand": false
+        "object-literal-shorthand": false,
+        "max-line-length": [
+            false
+        ]
     },
     "rulesDirectory": []
 }