Skip to content

Dummy long PR with public code #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 70 commits into
base: master
Choose a base branch
from
Open

Dummy long PR with public code #1

wants to merge 70 commits into from

Conversation

greglockwood
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

vicb and others added 30 commits September 23, 2016 10:18
…lar#11767)

TestBed was accidentaly ommited from the 'stable' api list during the API sweep before final. We do consider it to be stable.
…r#11786)

Fix(http): invalidStateError if response body without content
If the responseType has been specified and other than 'text', responseText throw an InvalidStateError exception

See XHR doc => https://xhr.spec.whatwg.org/#the-responsetext-attribute

Unit Test to prevent invalidStateError
The `addProvider` function in the `UpgradeAdapter` was deprecated in this [commit](angular@d21331e#diff-77163e956a7842149f583846c1c01651) and has been removed in final. Given this, the documentation for downgrading ng2 providers for use in ng1 is invalid.
vicb and others added 30 commits October 5, 2016 15:33
* docs(NgModule): Corrected the wording of the documentation of `entryComponents`, fixed some minor grammar issues

* docs(NgModule): Remove redundant ComponentFactory mentions

* docs(NgModule): Restore ComponentFactory/ComponentResolver links
npm doesn't currently support download counts for scoped packages, so there is no replacement right now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.