Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Getting Financial Data Exercise #108

Merged

Conversation

max-alletsee
Copy link
Contributor

@max-alletsee max-alletsee commented Aug 30, 2020

Using AlphaVantage API instead of Google Finance, which is not supported anymore by Pandas Datareader.

In the current version, the exercise is not working because Pandas Datareader does not support Google Finance anymore (due to some changes in the Google Finance API). This was noticed by some users of the pandas exercises, see e.g. issue #99 . As discussed in the issue report, I've re-written the exercise using the AlphaVantage API.

I've tried to keep the overall exercise similar and changes to a minimum, but two additional changes where necessary:

  1. The AlphaVantage API does not seem to return the ticker symbol; therefore, when requesting data for several symobols in the same request, it's ambiguous which data corresponds to which ticker symbol. To solve this issue, I'm sending separate API requests for each ticker symbol and then combine these via pd.concat().
  2. LinkedIn was bought by Microsoft, so there is no data available shortly after this purchase date. I've replaced the LinkedIn with Microsoft in the exercises.

I hope that this pull request is helpful and I'm more than happy to discuss it.

Using AlphaVantage API instead of Yahoo Finance, which is not supported anymore by Pandas Datareader
@guipsamora guipsamora merged commit e46948b into guipsamora:master Sep 18, 2020
@guipsamora
Copy link
Owner

Very cool!! Thanks a lot @max-alletsee ! 😊

@max-alletsee
Copy link
Contributor Author

You're welcome - and thanks a lot for accepting my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants