Fixing Getting Financial Data Exercise #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using AlphaVantage API instead of Google Finance, which is not supported anymore by Pandas Datareader.
In the current version, the exercise is not working because Pandas Datareader does not support Google Finance anymore (due to some changes in the Google Finance API). This was noticed by some users of the pandas exercises, see e.g. issue #99 . As discussed in the issue report, I've re-written the exercise using the AlphaVantage API.
I've tried to keep the overall exercise similar and changes to a minimum, but two additional changes where necessary:
I hope that this pull request is helpful and I'm more than happy to discuss it.