Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes subscription ID while validating image #473

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shubangmck
Copy link

If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:

Closes #472

@shubangmck shubangmck requested a review from a team as a code owner February 27, 2025 05:35
Copy link

hashicorp-cla-app bot commented Feb 27, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


shubangmck seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@@ -63,7 +63,7 @@ func (s *StepVerifySharedImageSource) Run(ctx context.Context, state multistep.S
s.SharedImageID))

galleryImageVersionID := galleryimageversions.NewImageVersionID(
azcli.SubscriptionID(),
resource.Subscription,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shubangmck thanks for this contribution, I notice another instance where we're setting the subscription ID from the az cli's subscription.

This change makes sense but on line 106 we query the Image after querying the Image Version ID, so wouldn't you also need to also override the subscription ID there to fix your issue?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JenGoldstrich Just updated my code, thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure chroot builder uses the current user's subscription to verify the image version existence
2 participants