Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for code scanning alert no. 98: Use of a broken or weak cryptographic algorithm #8265

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented Mar 18, 2025

Potential fix for https://github.com/hcengineering/platform/security/code-scanning/98

To fix the problem, we need to replace the SHA-1 hashing algorithm with a stronger one, such as SHA-256. This involves changing the createHash function call to use 'sha256' instead of 'sha1'. This change will ensure that the ETag is generated using a more secure hashing algorithm.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

… cryptographic algorithm

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Andrey Sobolev <haiodo@users.noreply.github.com>
@haiodo haiodo marked this pull request as ready for review March 18, 2025 15:33
@denis-tingaikin denis-tingaikin merged commit 3131214 into develop Mar 18, 2025
15 checks passed
@BykhovDenis BykhovDenis deleted the alert-autofix-98 branch March 24, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants