fix(ivy): throw a descriptive error when trying to insert / move destroyed view (angular#27289)

PR Close angular#27289

Author: pkozlowski-opensource

packages/core/src/render3/component_ref.ts

@@ -265,6 +265,7 @@ export class ComponentRef<T> extends viewEngine_ComponentRef<T> {
     ngDevMode && assertDefined(this.destroyCbs, 'NgModule already destroyed');
     this.destroyCbs !.forEach(fn => fn());
     this.destroyCbs = null;
+    this.hostView.destroy();
   }
   onDestroy(callback: () => void): void {
     ngDevMode && assertDefined(this.destroyCbs, 'NgModule already destroyed');

packages/core/src/render3/view_engine_compatibility.ts

@@ -265,6 +265,9 @@ export function createContainerRef(
       }
 
       move(viewRef: viewEngine_ViewRef, newIndex: number): viewEngine_ViewRef {
+        if (viewRef.destroyed) {
+          throw new Error('Cannot move a destroyed View in a ViewContainer!');
+        }
         const index = this.indexOf(viewRef);
         this.detach(index);
         this.insert(viewRef, this._adjustIndex(newIndex));

packages/core/test/linker/integration_spec.ts

@@ -995,17 +995,18 @@ function declareTests(config?: {useJit: boolean}) {
         expect(dir.receivedArgs).toEqual(['one', undefined]);
       });
 
-      fixmeIvy('unknown') && it('should not allow pipes in hostListeners', () => {
-        @Directive({selector: '[host-listener]', host: {'(click)': 'doIt() | somePipe'}})
-        class DirectiveWithHostListener {
-        }
+      fixmeIvy('FW-742: Pipes in host listeners should throw a descriptive error') &&
+          it('should not allow pipes in hostListeners', () => {
+            @Directive({selector: '[host-listener]', host: {'(click)': 'doIt() | somePipe'}})
+            class DirectiveWithHostListener {
+            }
 
-        TestBed.configureTestingModule({declarations: [MyComp, DirectiveWithHostListener]});
-        const template = '<div host-listener></div>';
-        TestBed.overrideComponent(MyComp, {set: {template}});
-        expect(() => TestBed.createComponent(MyComp))
-            .toThrowError(/Cannot have a pipe in an action expression/);
-      });
+            TestBed.configureTestingModule({declarations: [MyComp, DirectiveWithHostListener]});
+            const template = '<div host-listener></div>';
+            TestBed.overrideComponent(MyComp, {set: {template}});
+            expect(() => TestBed.createComponent(MyComp))
+                .toThrowError(/Cannot have a pipe in an action expression/);
+          });
 
 
 
@@ -1238,37 +1239,35 @@ function declareTests(config?: {useJit: boolean}) {
         });
 
         describe('.insert', () => {
-          fixmeIvy('unknown') &&
-              it('should throw with destroyed views', async(() => {
-                   const fixture = TestBed.configureTestingModule({schemas: [NO_ERRORS_SCHEMA]})
-                                       .createComponent(MyComp);
-                   const tc = fixture.debugElement.children[0].children[0];
-                   const dynamicVp: DynamicViewport = tc.injector.get(DynamicViewport);
-                   const ref = dynamicVp.create();
-                   fixture.detectChanges();
+          it('should throw with destroyed views', async(() => {
+               const fixture = TestBed.configureTestingModule({schemas: [NO_ERRORS_SCHEMA]})
+                                   .createComponent(MyComp);
+               const tc = fixture.debugElement.children[0].children[0];
+               const dynamicVp: DynamicViewport = tc.injector.get(DynamicViewport);
+               const ref = dynamicVp.create();
+               fixture.detectChanges();
 
-                   ref.destroy();
-                   expect(() => {
-                     dynamicVp.insert(ref.hostView);
-                   }).toThrowError('Cannot insert a destroyed View in a ViewContainer!');
-                 }));
+               ref.destroy();
+               expect(() => {
+                 dynamicVp.insert(ref.hostView);
+               }).toThrowError('Cannot insert a destroyed View in a ViewContainer!');
+             }));
         });
 
         describe('.move', () => {
-          fixmeIvy('unknown') &&
-              it('should throw with destroyed views', async(() => {
-                   const fixture = TestBed.configureTestingModule({schemas: [NO_ERRORS_SCHEMA]})
-                                       .createComponent(MyComp);
-                   const tc = fixture.debugElement.children[0].children[0];
-                   const dynamicVp: DynamicViewport = tc.injector.get(DynamicViewport);
-                   const ref = dynamicVp.create();
-                   fixture.detectChanges();
+          it('should throw with destroyed views', async(() => {
+               const fixture = TestBed.configureTestingModule({schemas: [NO_ERRORS_SCHEMA]})
+                                   .createComponent(MyComp);
+               const tc = fixture.debugElement.children[0].children[0];
+               const dynamicVp: DynamicViewport = tc.injector.get(DynamicViewport);
+               const ref = dynamicVp.create();
+               fixture.detectChanges();
 
-                   ref.destroy();
-                   expect(() => {
-                     dynamicVp.move(ref.hostView, 1);
-                   }).toThrowError('Cannot move a destroyed View in a ViewContainer!');
-                 }));
+               ref.destroy();
+               expect(() => {
+                 dynamicVp.move(ref.hostView, 1);
+               }).toThrowError('Cannot move a destroyed View in a ViewContainer!');
+             }));
         });
 
       });