Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR] Un-xfail variadic calls #1517

Merged
merged 1 commit into from
Mar 24, 2025
Merged

[CIR] Un-xfail variadic calls #1517

merged 1 commit into from
Mar 24, 2025

Conversation

AdUhTkJm
Copy link
Contributor

This un-xfails the 6 files in #1497 related to variadic calls.

@FantasqueX
Copy link
Collaborator

// Parse the function signature.
bool isVariadic = false;
if (function_interface_impl::parseFunctionSignature(
parser, /*allowVariadic=*/true, arguments, isVariadic, resultTypes,
resultAttrs))
return failure();
This parameter was true before rebasing. It's a mistake during rebase.

Copy link
Collaborator

@FantasqueX FantasqueX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcardosolopes bcardosolopes merged commit bff6c15 into llvm:main Mar 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants