We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace lvalue references with forwarding references for predicates and projections in algorithms helpers.
This point has been raised a couple of times in reviews:
Few helper functions already do this:
llvm-project/libcxx/include/__algorithm/is_permutation.h
Lines 73 to 80 in 96925fa
llvm-project/libcxx/include/__algorithm/ranges_partition.h
Line 47 in 96925fa
The text was updated successfully, but these errors were encountered:
Or even take by value and then pass around std::reference_wrapper. We should evaluate the pros/cons of each.
std::reference_wrapper
Sorry, something went wrong.
[libc++] Use forward referencing for predicates, projections, and com…
4027e30
…parators Propsed solution for issue llvm#133065
No branches or pull requests
Replace lvalue references with forwarding references for predicates and projections in algorithms helpers.
This point has been raised a couple of times in reviews:
Few helper functions already do this:
llvm-project/libcxx/include/__algorithm/is_permutation.h
Lines 73 to 80 in 96925fa
llvm-project/libcxx/include/__algorithm/ranges_partition.h
Line 47 in 96925fa
The text was updated successfully, but these errors were encountered: