Skip to content

[clang-tidy] "modernize-use-emplace" does not provide diagnostic for std::optional #133108

Open
@denzor200

Description

@denzor200
std::vector<std::pair<std::string, int>> v;
v.push_back(std::pair<std::string, int>("first", 1)); // OK - clang tidy provides warnings for that

std::optional<std::pair<std::string, int>> o;
o = std::pair<std::string, int>{"first", 1};          // BAD - silence

The full snippet here: https://godbolt.org/z/nW9dKscqo

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions