[Github] Bump CI container to ubuntu 24.04 #132568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis helps keep things up to date, and should not cause any issues given we do Full diff: https://github.com/llvm/llvm-project/pull/132568.diff 2 Files Affected:
diff --git a/.github/workflows/build-ci-container.yml b/.github/workflows/build-ci-container.yml
index 994435a8973b6..3159aae32ca51 100644
--- a/.github/workflows/build-ci-container.yml
+++ b/.github/workflows/build-ci-container.yml
@@ -44,7 +44,7 @@ jobs:
id: vars
run: |
tag=$(git rev-parse --short=12 HEAD)
- container_name="ghcr.io/$GITHUB_REPOSITORY_OWNER/${{ matrix.arch }}/ci-ubuntu-22.04"
+ container_name="ghcr.io/$GITHUB_REPOSITORY_OWNER/${{ matrix.arch }}/ci-ubuntu-24.04"
echo "container-name=$container_name" >> $GITHUB_OUTPUT
echo "container-name-agent=$container_name-agent" >> $GITHUB_OUTPUT
echo "container-name-tag=$container_name:$tag" >> $GITHUB_OUTPUT
diff --git a/.github/workflows/containers/github-action-ci/Dockerfile b/.github/workflows/containers/github-action-ci/Dockerfile
index ef4a11013acb3..a60c1ba019a99 100644
--- a/.github/workflows/containers/github-action-ci/Dockerfile
+++ b/.github/workflows/containers/github-action-ci/Dockerfile
@@ -1,4 +1,4 @@
-FROM docker.io/library/ubuntu:22.04 as base
+FROM docker.io/library/ubuntu:24.04 as base
ENV LLVM_SYSROOT=/opt/llvm
FROM base as stage1-toolchain
|
tstellar
approved these changes
Mar 27, 2025
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Mar 27, 2025
This helps keep things up to date, and should not cause any issues given we do not need to care about binary compatibility for things built in the CI container. This patch also changes the name of the container which allows incrementally moving jobs over after this lands. Pull Request: llvm#132568
Created using spr 1.3.4 [skip ci]
boomanaiden154
changed the base branch from
users/boomanaiden154/main.github-bump-ci-container-to-ubuntu-2404
to
main
boomanaiden154
deleted the
users/boomanaiden154/github-bump-ci-container-to-ubuntu-2404
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 27, 2025
This helps keep things up to date, and should not cause any issues given we do not need to care about binary compatibility for things built in the CI container. This patch also changes the name of the container which allows incrementally moving jobs over after this lands. Reviewers: tstellar Reviewed By: tstellar Pull Request: llvm/llvm-project#132568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps keep things up to date, and should not cause any issues given we do
not need to care about binary compatibility for things built in the CI
container. This patch also changes the name of the container which allows
incrementally moving jobs over after this lands.