[LoongArch] Allow recognition of b{lt,gt,le,ge}z in disassembly
#132620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-loongarch @llvm/pr-subscribers-mc Author: WÁNG Xuěruì (xen0n) ChangesThis behavior is implemented for GNU Binutils since 2.41, and benefits the readability of the disassembly output. Do the same for LLVM by removing the zero weight from the alias definitions respectively. Full diff: https://github.com/llvm/llvm-project/pull/132620.diff 2 Files Affected:
diff --git a/llvm/lib/Target/LoongArch/LoongArchInstrInfo.td b/llvm/lib/Target/LoongArch/LoongArchInstrInfo.td
index 9b93a9f824726..b16ab1905e4aa 100644
--- a/llvm/lib/Target/LoongArch/LoongArchInstrInfo.td
+++ b/llvm/lib/Target/LoongArch/LoongArchInstrInfo.td
@@ -2295,10 +2295,13 @@ def : InstAlias<"ret", (JIRL R0, R1, 0)>;
def : InstAlias<"jr $rj", (JIRL R0, GPR:$rj, 0)>;
// Branches implemented with alias.
-// Always output the canonical mnemonic for the pseudo branch instructions.
-// The GNU tools emit the canonical mnemonic for the branch pseudo instructions
-// as well (e.g. "bgt" will be recognised by the assembler but never printed by
-// objdump). Match this behaviour by setting a zero weight.
+// Disassemble branch instructions not having a $zero operand to the
+// canonical mnemonics respectively, but disassemble BLT/BGE with a $zero
+// operand to the corresponding pseudo-instruction.
+// GNU Binutils behave like this since 2.41, e.g. "bgt" will be recognised
+// by the assembler but never printed by objdump.
+// Match this behaviour by setting a zero weight for the b{gt,le}{,u}
+// patterns.
def : InstAlias<"bgt $rj, $rd, $imm16",
(BLT GPR:$rd, GPR:$rj, simm16_lsl2_br:$imm16), 0>;
def : InstAlias<"bgtu $rj, $rd, $imm16",
@@ -2308,13 +2311,13 @@ def : InstAlias<"ble $rj, $rd, $imm16",
def : InstAlias<"bleu $rj, $rd, $imm16",
(BGEU GPR:$rd, GPR:$rj, simm16_lsl2_br:$imm16), 0>;
def : InstAlias<"bltz $rd, $imm16",
- (BLT GPR:$rd, R0, simm16_lsl2_br:$imm16), 0>;
+ (BLT GPR:$rd, R0, simm16_lsl2_br:$imm16)>;
def : InstAlias<"bgtz $rj, $imm16",
- (BLT R0, GPR:$rj, simm16_lsl2_br:$imm16), 0>;
+ (BLT R0, GPR:$rj, simm16_lsl2_br:$imm16)>;
def : InstAlias<"blez $rj, $imm16",
- (BGE R0, GPR:$rj, simm16_lsl2_br:$imm16), 0>;
+ (BGE R0, GPR:$rj, simm16_lsl2_br:$imm16)>;
def : InstAlias<"bgez $rd, $imm16",
- (BGE GPR:$rd, R0, simm16_lsl2_br:$imm16), 0>;
+ (BGE GPR:$rd, R0, simm16_lsl2_br:$imm16)>;
// Load immediate.
let hasSideEffects = 0, mayLoad = 0, mayStore = 0, isCodeGenOnly = 0,
diff --git a/llvm/test/MC/LoongArch/Macros/aliases-br.s b/llvm/test/MC/LoongArch/Macros/aliases-br.s
index e8d85bdec763b..0e381c3aea7a9 100644
--- a/llvm/test/MC/LoongArch/Macros/aliases-br.s
+++ b/llvm/test/MC/LoongArch/Macros/aliases-br.s
@@ -9,10 +9,10 @@ ble $a1, $a0, 16
bleu $a1, $a0, 16
# CHECK-NEXT: bgeu $a0, $a1, 16
bltz $a0, 16
-# CHECK-NEXT: blt $a0, $zero, 16
+# CHECK-NEXT: bltz $a0, 16
bgtz $a0, 16
-# CHECK-NEXT: blt $zero, $a0, 16
+# CHECK-NEXT: bgtz $a0, 16
blez $a0, 16
-# CHECK-NEXT: bge $zero, $a0, 16
+# CHECK-NEXT: blez $a0, 16
bgez $a0, 16
-# CHECK-NEXT: bge $a0, $zero, 16
+# CHECK-NEXT: bgez $a0, 16
|
This behavior is implemented for GNU Binutils since 2.41, and benefits the readability of the disassembly output. Do the same for LLVM by removing the zero weight from the alias definitions respectively.
xen0n
force-pushed
the
loong-more-insn-aliases
branch
from
9a8d95b to
b779e13
Compare
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/9820 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior is implemented for GNU Binutils since 2.41, and benefits the readability of the disassembly output. Do the same for LLVM by removing the zero weight from the alias definitions respectively.