Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC][AMDGPU] Move buffer_load lds test from gfx11_asm_mubuf.s to gfx11_asm_mubuf_err.s #132938

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

jmmartinez
Copy link
Contributor

The test checked that the lds flag for buffer_load instructions was not supported. These should be moved to the _err counterpart of the tests.

…11_asm_mubuf_err.s

The test checked that the lds flag for buffer_load instructions was not
supported. These should be moved to the _err counterpart of the tests.
@jmmartinez jmmartinez requested a review from jayfoad March 25, 2025 14:40
@jmmartinez jmmartinez self-assigned this Mar 25, 2025
@llvmbot llvmbot added backend:AMDGPU mc Machine (object) code labels Mar 25, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 25, 2025

@llvm/pr-subscribers-backend-amdgpu

@llvm/pr-subscribers-mc

Author: Juan Manuel Martinez Caamaño (jmmartinez)

Changes

The test checked that the lds flag for buffer_load instructions was not supported. These should be moved to the _err counterpart of the tests.


Full diff: https://github.com/llvm/llvm-project/pull/132938.diff

2 Files Affected:

  • (modified) llvm/test/MC/AMDGPU/gfx11_asm_mubuf.s (+1-5)
  • (modified) llvm/test/MC/AMDGPU/gfx11_asm_mubuf_err.s (+3)
diff --git a/llvm/test/MC/AMDGPU/gfx11_asm_mubuf.s b/llvm/test/MC/AMDGPU/gfx11_asm_mubuf.s
index dfc017acfc570..a832dc922770e 100644
--- a/llvm/test/MC/AMDGPU/gfx11_asm_mubuf.s
+++ b/llvm/test/MC/AMDGPU/gfx11_asm_mubuf.s
@@ -1,5 +1,4 @@
-// RUN: not llvm-mc -triple=amdgcn -mcpu=gfx1100 -show-encoding %s | FileCheck --check-prefix=GFX11 %s
-// RUN: not llvm-mc -triple=amdgcn -mcpu=gfx1100 -show-encoding %s 2>&1 | FileCheck --check-prefixes=GFX11-ERR --implicit-check-not=error: %s
+// RUN: llvm-mc -triple=amdgcn -mcpu=gfx1100 -show-encoding %s | FileCheck --check-prefix=GFX11 %s
 
 buffer_gl0_inv
 // GFX11: encoding: [0x00,0x00,0xac,0xe0,0x00,0x00,0x00,0x00]
@@ -64,9 +63,6 @@ buffer_load_b32 v5, off, s[8:11], s3 offset:4095 dlc
 buffer_load_b32 v5, off, s[8:11], s3 offset:4095 glc slc dlc
 // GFX11: encoding: [0xff,0x7f,0x50,0xe0,0x00,0x05,0x02,0x03]
 
-buffer_load_b32 v5, off, s[8:11], s3 offset:4095 lds
-// GFX11-ERR: :[[@LINE-1]]:{{[0-9]+}}: error: invalid operand for instruction
-
 buffer_load_b64 v[5:6], off, s[8:11], s3 offset:4095
 // GFX11: encoding: [0xff,0x0f,0x54,0xe0,0x00,0x05,0x02,0x03]
 
diff --git a/llvm/test/MC/AMDGPU/gfx11_asm_mubuf_err.s b/llvm/test/MC/AMDGPU/gfx11_asm_mubuf_err.s
index 8c0d17075318d..a15090b31acf3 100644
--- a/llvm/test/MC/AMDGPU/gfx11_asm_mubuf_err.s
+++ b/llvm/test/MC/AMDGPU/gfx11_asm_mubuf_err.s
@@ -99,6 +99,9 @@ buffer_load_b128 v[5:8], v0, null, s3 offen offset:4095
 buffer_load_b32 v5, v0, null, s3 offen offset:4095
 // NOGFX11: :[[@LINE-1]]:{{[0-9]+}}: error: invalid operand for instruction
 
+buffer_load_b32 v5, off, s[8:11], s3 offset:4095 lds
+// NOGFX11: :[[@LINE-1]]:{{[0-9]+}}: error: invalid operand for instruction
+
 buffer_store_b64 v[1:2], v0, null, s4 idxen offset:4095
 // NOGFX11: :[[@LINE-1]]:{{[0-9]+}}: error: invalid operand for instruction
 

Copy link
Contributor

@jayfoad jayfoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmmartinez jmmartinez merged commit cc08826 into llvm:main Mar 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:AMDGPU mc Machine (object) code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants