Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libcxx] Add GitHub usernames for Linaro managed bots #133120

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

DavidSpickett
Copy link
Collaborator

This isn't the whole team, but enough that one of us will see it and make sure the right person sees it.

Noted explicitly that Picolibc is also our responsiblity as it's not always clear that that is tested on Arm.

This isn't the whole team, but enough that one of us will see it
and make sure the right person sees it.

Noted explicitly that Picolibc is also our responsiblity
as it's not always clear that that is tested on Arm.
@DavidSpickett DavidSpickett requested a review from a team as a code owner March 26, 2025 16:40
@DavidSpickett DavidSpickett requested a review from omjavaid March 26, 2025 16:40
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Mar 26, 2025
@DavidSpickett DavidSpickett requested review from ceseo and ldionne March 26, 2025 16:40
@llvmbot
Copy link
Member

llvmbot commented Mar 26, 2025

@llvm/pr-subscribers-libcxx

Author: David Spickett (DavidSpickett)

Changes

This isn't the whole team, but enough that one of us will see it and make sure the right person sees it.

Noted explicitly that Picolibc is also our responsiblity as it's not always clear that that is tested on Arm.


Full diff: https://github.com/llvm/llvm-project/pull/133120.diff

1 Files Affected:

  • (modified) libcxx/utils/ci/BOT_OWNERS.txt (+4-3)
diff --git a/libcxx/utils/ci/BOT_OWNERS.txt b/libcxx/utils/ci/BOT_OWNERS.txt
index de575c5913831..3a82bf6381c0d 100644
--- a/libcxx/utils/ci/BOT_OWNERS.txt
+++ b/libcxx/utils/ci/BOT_OWNERS.txt
@@ -5,12 +5,13 @@ cannot be figured out by the community alone.
 The list is sorted by surname and formatted to allow easy grepping and
 beautification by scripts. The fields are: name (N), email (E), web-address
 (W), PGP key ID and fingerprint (P), description (D), snail-mail address
-(S), Phabricator handle (H) and IRC handle (I). Each entry should contain at
-least the (N), (E) and (D) fields.
+(S), Phabricator handle (H), IRC handle (I) and GitHub username(s) (G).
+Each entry should contain at least the (N), (E) and (D) fields.
 
 N: Linaro Toolchain Working Group
 E: linaro-toolchain@lists.linaro.org
-D: Arm platforms
+D: Arm platforms and picolibc
+G: DavidSpickett, omjavaid, ceseo
 
 N: LLVM on Power
 E: powerllvm@ca.ibm.com

Copy link
Member

@mordante mordante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM from the libc++ side.

Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ldionne ldionne merged commit 3e59b00 into llvm:main Mar 26, 2025
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants