-
Notifications
You must be signed in to change notification settings - Fork 110
[BOLT] Rename Meta's Aarch64 workers and builders #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOLT] Rename Meta's Aarch64 workers and builders #459
Conversation
a8f7936
to
c9403e5
Compare
|
c9403e5
to
d9f62ef
Compare
Discussed with @aaupov and agreed to keep current AArch64 buildbot for now. Just adding that the upcoming buildbot runs on Ubuntu 24.04.2 LTS (6.8.0-1029-aws) without regressions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but @gkistanova needs to update the workers file
Thanks Amir. I've sent another patch to align with the below excerpt from the guide. Those folders are on the workers, but I'm not sure if the master uses them too. Either way, it's also more aligned with the builder's name.
Regarding the below:
Is this a manual step that happens when the workers are updated? |
This is a manual step. The new worker names need to exist in the database, otherwise they won't be allowed to connect (and repeated attempts to do so will get you IP banned, which needs to be manually removed too). So wait for Galina to confirm what needs to be done here. |
Okay. Thanks a lot for the info David. |
Just to note, this patch only renames the existing Meta-Managed AArch64-Buildbot; it does not drop it. The branch name is confusing; please ignore it. Unfortunately I can't rename it without opening a new PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you both. |
Done |
Thanks Amir. I see that the staging buildmaster, which automatically pulls changes every 2 hours, has already picked up the merged changes. The main buildmaster, where existing bolt buildbots are attached, would need a reboot by @gkistanova as it still uses the old name bolt-worker-aarch64? |
No description provided.