[BOLT] Excluding GNU build-id and cleanup. #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/bolt-nfc-check-validation
branch
from
86e9c12 to
94d5651
Compare
aaupov
requested changes
Jun 13, 2025
NFC-mode runs in-tree and out-of-tree (large BOLT tests) when there are changes affecting llvm-bolt between the current revision and the previous one. However, the revision SHA itself and the GNU build-id may be two unique differences when doing such a comparison. This patch introduces a lightweight sanity check step that reports a warning on the Buildbot so that we are aware when this occurs.
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/bolt-nfc-check-validation
branch
from
94d5651 to
55a3b78
Compare
Pass '--build-id' to the linker to disable emission of a unique build ID into a note section. This breaks nfc-mode tests. Additional cleanup: - Out-of-tree tests are now labeled as 'BOLT large tests' - Dropped step 'nfc-stat-check' as it was disabled - Removed unused flags for Non-NFC tests
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/gnu-buildid-and-cleanup
branch
from
cdd7fc9 to
cf41ec9
Compare
|
Forced push to rebase on the PR stack. Also addressed comments. |
|
A gentle ping on this. 🙂 |
The default value for checks in addNinjaSteps is None. This patch adds the check steps only when they are not None.
paschalis-mpeis
changed the base branch from
users/paschalis-mpeis/bolt-nfc-check-validation
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass '--build-id' to the linker to disable emission of a unique build ID into a note section. This breaks nfc-mode tests.
Additional cleanup: