fix(CodeReview): diff解析失败时增加判空操作 (DevCloudFE#1731)

* fix(CodeReview): diff解析失败时增加判空操作

* fix: 修复中

* fix(CodeReview): 增加判空操作

* fix(CodeReview): 还原demo

---------

Co-authored-by: GreatZP <greatzp@greatzp.cn>

Author: xingyan95

packages/devui-vue/devui/code-review/src/composables/use-code-review-expand.ts

@@ -45,10 +45,15 @@ export function useCodeReviewExpand(reviewContentRef: Ref<HTMLElement>, props: C
     }
 
     const loadMoreLine = trNodes[0].cloneNode(true) as HTMLTableRowElement;
-    loadMoreLine.children[0].removeChild(loadMoreLine.children[0].children[0]);
+    if (loadMoreLine.children[0].children[0]) {
+      loadMoreLine.children[0].removeChild(loadMoreLine.children[0].children[0]);
+    }
     (loadMoreLine.children[1] as HTMLElement).innerText = '';
+    const res = updateLineNumberInDatasetForDoubleColumn(loadMoreLine, expandThreshold.value, 'bottom');
+    if (!res) {
+      return;
+    }
     trNodes[0].parentElement?.appendChild(loadMoreLine);
-    updateLineNumberInDatasetForDoubleColumn(loadMoreLine, expandThreshold.value, 'bottom');
     attachExpandUpDownButton(loadMoreLine.children[0] as HTMLElement, 'down');
   };
 
@@ -139,10 +144,15 @@ export function useCodeReviewExpand(reviewContentRef: Ref<HTMLElement>, props: C
     }
 
     const loadMoreLine = trNodes[0].cloneNode(true) as HTMLTableRowElement;
-    loadMoreLine.children[0].removeChild(loadMoreLine.children[0].children[0]);
+    if (loadMoreLine.children[0].children[0]) {
+      loadMoreLine.children[0].removeChild(loadMoreLine.children[0].children[0]);
+    }
     (loadMoreLine.children[1] as HTMLElement).innerText = '';
+    const res = updateLineNumberInDataset(loadMoreLine, expandThreshold.value, 'bottom');
+    if (!res) {
+      return;
+    }
     trNodes[0].parentElement?.appendChild(loadMoreLine);
-    updateLineNumberInDataset(loadMoreLine, expandThreshold.value, 'bottom');
     attachExpandUpDownButton(loadMoreLine.children[0] as HTMLElement, 'down');
   };
 

packages/devui-vue/devui/code-review/src/utils.ts

@@ -226,9 +226,9 @@ export function updateLineNumberInDatasetForDoubleColumn(
     prevR = Math.max(nextR - expandThreshold + 1, 1);
   } else if (position === 'bottom') {
     const prevLineNode = trNode.previousElementSibling as HTMLElement;
-    prevL = parseInt((prevLineNode.children[0] as HTMLElement).innerText) + 1;
+    prevL = parseInt((prevLineNode?.children[0] as HTMLElement)?.innerText) + 1;
     nextL = prevL + expandThreshold - 1;
-    prevR = parseInt((prevLineNode.children[2] as HTMLElement).innerText) + 1;
+    prevR = parseInt((prevLineNode?.children[2] as HTMLElement)?.innerText) + 1;
     nextR = prevR + expandThreshold - 1;
   } else {
     const prevLineNode = trNode.previousElementSibling as HTMLElement;
@@ -244,7 +244,11 @@ export function updateLineNumberInDatasetForDoubleColumn(
       updateExpandUpDownButton(trNode);
     }
   }
+  if (isNaN(prevL) || isNaN(prevR) || isNaN(nextL) || isNaN(nextR)) {
+    return false;
+  }
   setLineNumberInDataset(trNode, prevL, prevR, nextL, nextR);
+  return true;
 }
 
 /*
@@ -272,9 +276,9 @@ export function updateLineNumberInDataset(
     prevR = Math.max(nextR - expandThreshold + 1, 1);
   } else if (position === 'bottom') {
     const prevLineNode = trNode.previousElementSibling as HTMLElement;
-    prevL = parseInt((prevLineNode.children[0].children[0] as HTMLElement).innerText) + 1;
+    prevL = parseInt((prevLineNode?.children[0].children?.[0] as HTMLElement)?.innerText) + 1;
     nextL = prevL + expandThreshold - 1;
-    prevR = parseInt((prevLineNode.children[0].children[1] as HTMLElement).innerText) + 1;
+    prevR = parseInt((prevLineNode?.children[0].children?.[1] as HTMLElement)?.innerText) + 1;
     nextR = prevR + expandThreshold - 1;
   } else {
     const prevLineNode = trNode.previousElementSibling as HTMLElement;
@@ -290,7 +294,11 @@ export function updateLineNumberInDataset(
       updateExpandUpDownButton(trNode);
     }
   }
+  if (isNaN(prevL) || isNaN(prevR) || isNaN(nextL) || isNaN(nextR)) {
+    return false;
+  }
   setLineNumberInDataset(trNode, prevL, prevR, nextL, nextR);
+  return true;
 }
 
 /*