Implemented Support for PlaceholderAPI Expansions #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You probably should have asked before doing this. DemonWav is doing a refactor to the project creator system, which means you will have to mostly rewrite this. |
|
The refactor is done, and from our discussion on Discord I think adding PlaceholderAPI as an enableable feature or extension on the existing platforms is the better option. With the new system you can potentially just create a single |
DenWav
force-pushed
the
dev
branch
5 times, most recently
from
f4dec0b to
5ca2d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements support for PlaceholderAPI Expansions. The only thing I have yet to figure out is why it's not detecting properly to show the icon. Currently, it will appear as a Spigot project.
Other than that, I believe this PR is done. Open to feedback.