[nrf fromlist] drivers: nrf_ironside dvfs service #2921
Merged
+296
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
4 times, most recently
from
4bc4cf5 to
d7a066a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
from
d7a066a to
8daeb2e
Compare
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
3 times, most recently
from
824b852 to
7a4a910
Compare
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
3 times, most recently
from
d416e17 to
726cc7e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds new support for the IRONside DVFS service by introducing DVFS service API, configuration options, and driver implementation while making NRFS DVFS not enabled by default.
- Conditional inclusion of DVFS service headers and sources in Nordic HAL CMake configurations.
- New header and driver implementation to define DVFS oppoints, error codes, and DVFS operations.
- Addition of Kconfig options to enable the DVFS service and set the oppoint change mutex timeout.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| modules/hal_nordic/nrfs/CMakeLists.txt | Replaces unconditional includes with conditional ones for DVFS service support. |
| include/zephyr/drivers/firmware/nrf_ironside/dvfs.h | Introduces DVFS API definitions, error codes, and inline validations. |
| drivers/firmware/nrf_ironside/dvfs.c | Implements DVFS oppoint change flow and related hardware configurations. |
| drivers/firmware/nrf_ironside/Kconfig | Adds configuration options for the DVFS service and timeout parameter. |
| drivers/firmware/nrf_ironside/CMakeLists.txt | Conditionally includes the DVFS driver source based on the service configuration. |
Comments suppressed due to low confidence (2)
modules/hal_nordic/nrfs/CMakeLists.txt:17
- The conditional macro 'CONFIG_NRFS_HAS_DVFS_SERVICE' used here differs from the Kconfig option 'NRF_IRONSIDE_DVFS_SERVICE'. Consider aligning the configuration macro names for consistency.
zephyr_include_directories_ifdef(CONFIG_NRFS_HAS_DVFS_SERVICE ${HELPERS_DIR})
modules/hal_nordic/nrfs/CMakeLists.txt:22
- The use of 'CONFIG_NRFS_HAS_DVFS_SERVICE' here is inconsistent with the Kconfig definition 'NRF_IRONSIDE_DVFS_SERVICE'. Standardize the configuration macro across the codebase.
zephyr_library_sources_ifdef(CONFIG_NRFS_HAS_DVFS_SERVICE ${HELPERS_DIR}/dvfs_oppoint.c)
| int "IRONSside DVFS change oppoint mutex timeout" | ||
| default 100 | ||
| help | ||
| Maximum tiemout when waiting for DVFS oppoint change mutex lock. |
There was a problem hiding this comment.
The word 'tiemout' appears to be a misspelling. It should be corrected to 'timeout'.
Suggested change
| Maximum tiemout when waiting for DVFS oppoint change mutex lock. | |
| Maximum timeout when waiting for DVFS oppoint change mutex lock. |
Copilot uses AI. Check for mistakes.
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
from
726cc7e to
1af32a0
Compare
karstenkoenig
approved these changes
Jun 24, 2025
Added handling of new IRONside DVFS service. NRFS DVFS is now not enabled by default. Signed-off-by: Łukasz Stępnicki <lukasz.stepnicki@nordicsemi.no> (cherry picked from commit a0777734de0c33a1341ce57747590fc268cf85ea)
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
from
1af32a0 to
a66fce3
Compare
|
karl-nordic
approved these changes
Jun 24, 2025
bjarki-andreasen
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling of new IRONside DVFS service.
NRFS DVFS is now not enabled by default.
Upstream PR #: 90755