-
Notifications
You must be signed in to change notification settings - Fork 677
ironside tdd service #2938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ironside tdd service #2938
Conversation
__constant U32 _CORESIGHT_CLAIMSET_OFFSET = 0xFA0; | ||
__constant U32 _CORESIGHT_CLAIMCLR_OFFSET = 0xFA4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This usage of the CLAIM register is not standardized, but instead a bespoke solution that we made. Should we leave CLAIM configuration out here? It could always be added later if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this is in a nordic specific file I feel this is ok, we aren't providing a general jlink script to configure coresight peripherals here
9b827dd
to
079ffa6
Compare
#if defined(CONFIG_SOC_NRF54H20_ENABLE_TDD) | ||
int err_tdd; | ||
|
||
err_tdd = ironside_se_tdd_configure(IRONSIDE_SE_TDD_CONFIG_ON_DEFAULT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also be invoked by PM state changes, if I'm not misunderstanding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a final solution it can be, right now this will just force on tdd and leave it at that, hence preventing having to reconfigure all the coresight peripherals after a sleep etc, because JLink couldn't handle this.
This can be done when we have the coresight peripherals controlled from the application core but that'll need more time while this allows ETM over TPIU as a static state and is useful like this as is, just not power efficient
ce33c40
to
d8082ca
Compare
e51d881
to
d89da5d
Compare
d89da5d
to
ac03d99
Compare
@57300 I dropped the JLink change as we can pull this into a designated commit and PR to enable ETM |
ac03d99
to
95d6e70
Compare
95d6e70
to
15a91bd
Compare
4fd8117
to
1544533
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream CI is completely red and has no approvals
aa1bee3
to
2976389
Compare
2976389
to
062acd8
Compare
@nordicjm upstream CI is green after cherry-picking a fix from a different PR, so added this here as well. Can you please check again? You will notice a [noup] commit, sadly this can't be done upstream yet as it can go on relies on two different upstream PRs and hence doesn't have a place upstream, we can only do this after those get merged after the feature PRs are allowed again. I opened NCSDK-34289 against myself to follow up on this commit |
Added support for the IronSide TDD service which allows configuring and powering the trace and debug domain of the nrf54h20. Also provide option to start the trace and debug domain in the soc start sequence. Upstream PR #: 92340 Signed-off-by: Karsten Koenig <karsten.koenig@nordicsemi.no>
Added support for ETM tracing via TPIU to the JLinkScript. Upstream PR #: 92340 Signed-off-by: Karsten Koenig <karsten.koenig@nordicsemi.no>
062acd8
to
b1018d6
Compare
Configure the CTRLSET value and the clock pin so that the TRACE pins work when the TDD gets used. Signed-off-by: Karsten Koenig <karsten.koenig@nordicsemi.no>
|
Added support for the IronSide TDD service which allows configuring and
powering the trace and debug domain of the nrf54h20.
Also provide option to start the trace and debug domain in the soc start
sequence.