Skip to content

Commit ec6dc78

Browse files
committed
Revert "build: convert CLDR locale extraction from Gulp to Bazel tool (angular#42230)" (angular#42583)
This reverts commit 1eaeb23. PR Close angular#42583
1 parent 877cde8 commit ec6dc78

31 files changed

+1294
-1278
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,8 @@ baseline.json
5050
# Ignore .history for the xyz.local-history VSCode extension
5151
.history
5252

53+
# CLDR data
54+
tools/gulp-tasks/cldr/cldr-data/
55+
5356
# Husky
5457
.husky/_

WORKSPACE

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -62,18 +62,3 @@ sass_repositories()
6262
load("@io_bazel_skydoc//skylark:skylark.bzl", "skydoc_repositories")
6363

6464
skydoc_repositories()
65-
66-
load("//packages/common/locales/generate-locales-tool:cldr-data.bzl", "cldr_data_repository")
67-
68-
cldr_data_repository(
69-
name = "cldr_data",
70-
# Since we use the Github archives for CLDR 37, we need to specify a path
71-
# to the available locales. This wouldn't be needed with CLDR 39 as that
72-
# comes with an official JSON archive not containing a version suffix.
73-
available_locales_path = "cldr-core-37.0.0/availableLocales.json",
74-
urls = {
75-
"https://github.com/unicode-cldr/cldr-core/archive/37.0.0.zip": "32b5c49c3874aa342b90412c207b42e7aefb2435295891fb714c34ce58b3c706",
76-
"https://github.com/unicode-cldr/cldr-dates-full/archive/37.0.0.zip": "e1c410dd8ad7d75df4a5393efaf5d28f0d56c0fa126c5d66e171a3f21a988a1e",
77-
"https://github.com/unicode-cldr/cldr-numbers-full/archive/37.0.0.zip": "a921b90cf7f436e63fbdd55880f96e39a203acd9e174b0ceafa20a02c242a12e",
78-
},
79-
)

gulpfile.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,6 @@ function loadTask(fileName, taskName) {
2020

2121
gulp.task('source-map-test', loadTask('source-map-test'));
2222
gulp.task('changelog:zonejs', loadTask('changelog-zonejs'));
23+
gulp.task('cldr:extract', loadTask('cldr', 'extract'));
24+
gulp.task('cldr:download', loadTask('cldr', 'download'));
25+
gulp.task('cldr:gen-closure-locale', loadTask('cldr', 'closure'));

package.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@
164164
"@bazel/buildifier": "^4.0.1",
165165
"@bazel/ibazel": "^0.15.8",
166166
"@octokit/graphql": "^4.6.1",
167-
"@types/cldrjs": "^0.4.22",
168167
"@types/cli-progress": "^3.4.2",
169168
"@types/conventional-commits-parser": "^3.0.1",
170169
"@types/ejs": "^3.0.6",
@@ -174,7 +173,8 @@
174173
"browserstacktunnel-wrapper": "^2.0.4",
175174
"check-side-effects": "0.0.23",
176175
"clang-format": "^1.4.0",
177-
"cldr": "5.7.0",
176+
"cldr": "7.0.0",
177+
"cldr-data-downloader": "^0.3.5",
178178
"cldrjs": "0.5.5",
179179
"cli-progress": "^3.7.0",
180180
"conventional-changelog": "^3.1.24",
@@ -217,5 +217,6 @@
217217
"@babel/template": "7.8.6",
218218
"@babel/traverse": "7.8.6",
219219
"@babel/types": "7.8.6"
220-
}
220+
},
221+
"cldr-data-coverage": "full"
221222
}

packages/common/locales/generate-locales-tool/BUILD.bazel

Lines changed: 0 additions & 17 deletions
This file was deleted.

packages/common/locales/generate-locales-tool/array-deduplication.ts

Lines changed: 0 additions & 35 deletions
This file was deleted.

packages/common/locales/generate-locales-tool/bin/BUILD.bazel

Lines changed: 0 additions & 33 deletions
This file was deleted.

packages/common/locales/generate-locales-tool/bin/base-locale.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

packages/common/locales/generate-locales-tool/bin/get-base-currencies-file.ts

Lines changed: 0 additions & 23 deletions
This file was deleted.

packages/common/locales/generate-locales-tool/bin/get-base-locale-file.ts

Lines changed: 0 additions & 25 deletions
This file was deleted.

0 commit comments

Comments
 (0)