Skip to content

8353309: Open source several Swing text tests #24364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Apr 1, 2025

Open source several Swing text / html related regression tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353309: Open source several Swing text tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24364/head:pull/24364
$ git checkout pull/24364

Update a local copy of the PR:
$ git checkout pull/24364
$ git pull https://git.openjdk.org/jdk.git pull/24364/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24364

View PR using the GUI difftool:
$ git pr show -t 24364

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24364.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2025

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353309: Open source several Swing text tests

Reviewed-by: aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

  • 3ceabf0: 8353359: C2: Or(I|L)Node::Ideal is missing AddNode::Ideal call
  • b263292: 8353484: JFR: Simplify EventConfiguration
  • ffca4f2: 8353264: ZGC: Windows heap unreserving is broken
  • f7a94fe: 8352585: Add special case handling for Float16.max/min x86 backend
  • 9c5ed23: 8349988: Change cgroup version detection logic to not depend on /proc/cgroups
  • 00a038e: 8353341: C2: removal of a Mod[DF]Node crashes when the node is already dead
  • bd74922: 8338675: javac shouldn't silently change .jar files on the classpath
  • 8d3d1d4: 8353058: [PPC64] Some IR framework tests are failing after JDK-8352595
  • b01026a: 8353325: Rewrite appcds/methodHandles test cases to use CDSAppTester
  • e2e1598: 8353584: [BACKOUT] DaCapo xalan performance with -XX:+UseObjectMonitorTable
  • ... and 69 more: https://git.openjdk.org/jdk/compare/3d2c3cd40ebce901d09a2479c267342e04e6f79c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8353309 8353309: Open source several Swing text tests Apr 1, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 1, 2025
@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 1, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 2, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 2, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 3, 2025
@prrace
Copy link
Contributor Author

prrace commented Apr 4, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

Going to push as commit 31a6de2.
Since your change was applied there have been 103 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2025
@openjdk openjdk bot closed this Apr 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@prrace Pushed as commit 31a6de2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants