8353320: Open source more Swing text tests #24365

prrace · 2025-04-01T18:34:22Z

Swing text related tests being moved to open source.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8353320: Open source more Swing text tests (Bug - P4)

Reviewers

Sergey Bylokhov (@mrserb - Reviewer) Review applies to cccd3959
Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24365/head:pull/24365
$ git checkout pull/24365

Update a local copy of the PR:
$ git checkout pull/24365
$ git pull https://git.openjdk.org/jdk.git pull/24365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24365

View PR using the GUI difftool:
$ git pr show -t 24365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24365.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-04-01T18:35:16Z

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-04-01T18:36:19Z

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353320: Open source more Swing text tests

Reviewed-by: aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

b263292: 8353484: JFR: Simplify EventConfiguration
ffca4f2: 8353264: ZGC: Windows heap unreserving is broken
f7a94fe: 8352585: Add special case handling for Float16.max/min x86 backend
9c5ed23: 8349988: Change cgroup version detection logic to not depend on /proc/cgroups
00a038e: 8353341: C2: removal of a Mod[DF]Node crashes when the node is already dead
bd74922: 8338675: javac shouldn't silently change .jar files on the classpath
8d3d1d4: 8353058: [PPC64] Some IR framework tests are failing after JDK-8352595
b01026a: 8353325: Rewrite appcds/methodHandles test cases to use CDSAppTester
e2e1598: 8353584: [BACKOUT] DaCapo xalan performance with -XX:+UseObjectMonitorTable
814730e: 8352645: Add tool support to check order of includes
... and 68 more: https://git.openjdk.org/jdk/compare/3d2c3cd40ebce901d09a2479c267342e04e6f79c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-04-01T18:37:13Z

@prrace The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-04-01T18:42:44Z

Webrevs

01: Full - Incremental (9d540f04)
00: Full (cccd3959)

test/jdk/javax/swing/text/html/FrameView/4463014/bug4463014.java

aivanov-jdk · 2025-04-02T16:18:44Z

test/jdk/javax/swing/text/html/FrameView/4463014/bug4463014.java

+        } catch (Exception e) {
+        }


Suggested change

} catch (Exception e) {

}

} catch (Exception e) {

thrown new RuntimeException(e);

}

The test should fail if an exception occurs.

aivanov-jdk · 2025-04-02T16:19:35Z

test/jdk/javax/swing/text/html/FrameView/4463014/frameset.html

+  <FRAME SRC="frame1.html">
+  <FRAME name="main" SRC="frame2.html">
+ </FRAMESET>
+</HTML>


A blank line in the end of file?

Not that I can see .. even doing a binary dump, and I didn't edit this file at all, I just moved it from closed to open.

aivanov-jdk · 2025-04-02T16:22:06Z

test/jdk/javax/swing/text/html/HTMLEditorKit/bug4102068.java

+
+/* @test
+ * @bug 4102068
+ * @summary Tests that JTextPane with HTMLEditorKit handles the HEAD tag properly


The summary doesn't match the instructions.

The test verifies if the cursor for text and for hyperlinks can be changed, doesn't it?

aivanov-jdk · 2025-04-02T16:23:34Z

test/jdk/javax/swing/text/html/HTMLEditorKit/bug4198022.java

+
+/* @test
+ * @bug 4198022
+ * @summary Tests that JTextPane with HTMLEditorKit handles the HEAD tag properly


The summary doesn't match the instructions.

aivanov-jdk · 2025-04-02T16:24:42Z

test/jdk/javax/swing/text/html/HTMLEditorKit/bug4245401.java

+        } catch (Exception e) {
+        }


If an exception occurs, the test should fail; the exception shouldn't be silently ignored.

Not something I added but I can re-throw as RTE. I verified that will cause the test to fail.

prrace · 2025-04-04T18:16:11Z

/integrate

openjdk · 2025-04-04T18:16:57Z

Going to push as commit 74c2d8f.
Since your change was applied there have been 104 commits pushed to the master branch:

31a6de2: 8353309: Open source several Swing text tests
3cc43b3: 8349075: Once again allow -compilejdk in JAVA_OPTIONS
9fb3609: 8350774: Generated test- targets broken after JDK-8348998
5520ff1: 8340341: Abort in configure when using Xcode 16.0 or 16.1
3670fde: 8349467: INIT_TARGETS tab completions on "make" lost with JDK-8348998
3241b4e: 8353066: Properly detect Windows/aarch64 as build platform
37f8e41: 8347645: C2: XOR bounded value handling blocks constant folding
4dca735: 8315844: $LSB_RELEASE is not defined before use
b92a443: 8353471: ZGC: Redundant generation id in ZGeneration
cfcb330: 8353681: jpackage suppresses errors when executed with --verbose option
... and 94 more: https://git.openjdk.org/jdk/compare/3d2c3cd40ebce901d09a2479c267342e04e6f79c...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-04-04T18:17:04Z

@prrace Pushed as commit 74c2d8f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8353320

cccd395

openjdk bot changed the title ~~8353320~~ 8353320: Open source more Swing text tests Apr 1, 2025

openjdk bot added the rfr label Apr 1, 2025

openjdk bot added the client label Apr 1, 2025

mrserb approved these changes Apr 2, 2025

View reviewed changes

openjdk bot added the ready label Apr 2, 2025

aivanov-jdk suggested changes Apr 2, 2025

View reviewed changes

8353320

9d540f0

openjdk bot removed the ready label Apr 2, 2025

aivanov-jdk approved these changes Apr 3, 2025

View reviewed changes

openjdk bot added the ready label Apr 3, 2025

openjdk bot added the integrated label Apr 4, 2025

openjdk bot closed this Apr 4, 2025

openjdk bot removed ready rfr labels Apr 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8353320: Open source more Swing text tests #24365

8353320: Open source more Swing text tests #24365

prrace commented Apr 1, 2025 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 1, 2025

openjdk bot commented Apr 1, 2025 •

edited

Loading

openjdk bot commented Apr 1, 2025

mlbridge bot commented Apr 1, 2025 •

edited

Loading

aivanov-jdk Apr 2, 2025

aivanov-jdk Apr 2, 2025

prrace Apr 2, 2025

aivanov-jdk Apr 2, 2025

prrace Apr 2, 2025

aivanov-jdk Apr 2, 2025

prrace Apr 2, 2025

aivanov-jdk Apr 2, 2025

prrace Apr 2, 2025

aivanov-jdk Apr 3, 2025

prrace commented Apr 4, 2025

openjdk bot commented Apr 4, 2025

openjdk bot commented Apr 4, 2025

8353320: Open source more Swing text tests #24365

8353320: Open source more Swing text tests #24365

Conversation

prrace commented Apr 1, 2025 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Apr 1, 2025

openjdk bot commented Apr 1, 2025 • edited Loading

openjdk bot commented Apr 1, 2025

mlbridge bot commented Apr 1, 2025 • edited Loading

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prrace commented Apr 4, 2025

openjdk bot commented Apr 4, 2025

openjdk bot commented Apr 4, 2025

prrace commented Apr 1, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Apr 1, 2025 •

edited

Loading

mlbridge bot commented Apr 1, 2025 •

edited

Loading