8352997: Open source several Swing JTabbedPane tests

[prrace]

open sourcing some Swing JTabbedPane tests

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Patch contains a binary file (test/jdk/javax/swing/JTabbedPane/4287208/duke.gif)

Issue

• JDK-8352997: Open source several Swing JTabbedPane tests (Bug - P4)

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)
• Harshitha Onkar (@honkar-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24370/head:pull/24370
$ git checkout pull/24370

Update a local copy of the PR:
$ git checkout pull/24370
$ git pull https://git.openjdk.org/jdk.git pull/24370/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24370

View PR using the GUI difftool:
$ git pr show -t 24370

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24370.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352997: Open source several Swing JTabbedPane tests

Reviewed-by: azvegint, serb, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 131 new commits pushed to the master branch:

• 57df89c: 8353684: [BACKOUT] j.u.l.Handler classes create deadlock risk via synchronized publish() method
• ebcb9a8: 8349206: j.u.l.Handler classes create deadlock risk via synchronized publish() method
• d894b78: 8353588: [REDO] DaCapo xalan performance with -XX:+UseObjectMonitorTable
• db08726: 8352966: Opensource Several Font related tests - Batch 2
• 6b7b324: 8351431: Type annotations on new class creation expressions can't be retrieved
• 64b691a: 8271870: G1: Add objArray splitting when scanning object with evacuation failure
• b428cda: 8349686: [s390x] C1: Improve Class.isInstance intrinsic
• 70e3250: 8352419: Test tools/jpackage/share/ErrorTest.java#id0 and #id1 fail
• 296d9d6: 8353345: C2 asserts because maskShiftAmount modifies node without deleting the hash
• 3ceabf0: 8353359: C2: Or(I|L)Node::Ideal is missing AddNode::Ideal call
• ... and 121 more: https://git.openjdk.org/jdk/compare/53926742c02480def6a42683fcaf284b99bcb0a1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9214ef6f)

[honkar-jdk]

Might be good to wrap it in EDT.

It was the following getComponentBounds() method that @azvegint suggested we move to Util (since we use it across multiple tests), but it does create a dependency on Util class.

Rectangle jtpLoc = Util.invokeOnEDT(() ->
                                        getComponentBounds(jtp));

private static Rectangle getComponentBounds(Component component) {
        Point locationOnScreen = component.getLocationOnScreen();
        Dimension size = component.getSize();
        return new Rectangle(locationOnScreen, size);
}

[prrace]

As I said when it was discussed, I like to avoid dependencies just for the sake of a few lines of code.

[honkar-jdk]

Yes, I agree it does create extra layer of dependency if Util is used.
Would it be good to wrap JTabbedPane's location and size in EDT (without using Util call) for stability?

[honkar-jdk]

On EDT ?

[prrace]

I don't think it is needed here because the UI is stable and so access should be safe.

[prrace]

/integrate

[openjdk]

Going to push as commit 9fcb06f.
Since your change was applied there have been 148 commits pushed to the master branch:

• 74c2d8f: 8353320: Open source more Swing text tests
• 31a6de2: 8353309: Open source several Swing text tests
• 3cc43b3: 8349075: Once again allow -compilejdk in JAVA_OPTIONS
• 9fb3609: 8350774: Generated test- targets broken after JDK-8348998
• 5520ff1: 8340341: Abort in configure when using Xcode 16.0 or 16.1
• 3670fde: 8349467: INIT_TARGETS tab completions on "make" lost with JDK-8348998
• 3241b4e: 8353066: Properly detect Windows/aarch64 as build platform
• 37f8e41: 8347645: C2: XOR bounded value handling blocks constant folding
• 4dca735: 8315844: $LSB_RELEASE is not defined before use
• b92a443: 8353471: ZGC: Redundant generation id in ZGeneration
• ... and 138 more: https://git.openjdk.org/jdk/compare/53926742c02480def6a42683fcaf284b99bcb0a1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit 9fcb06f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.