8353585: Provide ChoiceFormat#parse(String, ParsePosition) tests #24395
Conversation
|
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
|
@justin-curtis-lu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@justin-curtis-lu The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
| Arguments.of("1#baz", "foo bar baz", 1d, 8), | ||
| Arguments.of("1#baz", "foo baz quux", Double.NaN, 8), | ||
| Arguments.of("1#a", "", Double.NaN, 0), | ||
| Arguments.of("1#a", "a", 1d, 0), | ||
| Arguments.of("1# ", " ", 1d, 0), | ||
| Arguments.of("1#a|2#a", "a", 1d, 0), | ||
| Arguments.of("1#a|2#aa", "aa", 2d, 0), | ||
| Arguments.of("1#a|2#aa", "aabb", 2d, 0), | ||
| Arguments.of("1#a|2#aa", "bbaa", Double.NaN, 0), | ||
| Arguments.of("1#aa|2#aaa", "a", Double.NaN, 0) |
There was a problem hiding this comment.
Might be useful if we had negative or beyond input length position cases, which should produce NaN
|
/integrate |
|
Going to push as commit fd2734e.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
@justin-curtis-lu Pushed as commit fd2734e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this PR which provides unit tests for
ChoiceFormat#parse(String, ParsePosition)to check default, multi match, and no match behavior. There were no existing relevant tests.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24395/head:pull/24395$ git checkout pull/24395Update a local copy of the PR:
$ git checkout pull/24395$ git pull https://git.openjdk.org/jdk.git pull/24395/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24395View PR using the GUI difftool:
$ git pr show -t 24395Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24395.diff
Using Webrev
Link to Webrev Comment