Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8351851: Update PmemTest to run on AMD64 #24416

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frkator
Copy link
Member

@frkator frkator commented Apr 3, 2025

review to facilitate visibility on changes prior to testing @bwhuang-us


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351851: Update PmemTest to run on AMD64 (Task - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24416/head:pull/24416
$ git checkout pull/24416

Update a local copy of the PR:
$ git checkout pull/24416
$ git pull https://git.openjdk.org/jdk.git pull/24416/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24416

View PR using the GUI difftool:
$ git pr show -t 24416

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24416.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 3, 2025

👋 Welcome back isipka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Apr 3, 2025

@frkator The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Apr 3, 2025
@frkator frkator changed the title all OS architectures are treated equally 8351851: all OS architectures are treated equally Apr 3, 2025
@frkator frkator changed the title 8351851: all OS architectures are treated equally 8351851: Update PmemTest to run on AMD64 Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant