8353694: Resolved Class/Field/Method CP entries missing from AOT Configuration

[iklam]

This bug was discovered and fixed in the Leyden repo. Now the constant pool class/field/method entries that were resolved in the training will be recorded in the AOT config file, so they will be AOT-resolved during cache assembly.

@iwanowww @shipilev could you review?

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353694: Resolved Class/Field/Method CP entries missing from AOT Configuration (Bug - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24434/head:pull/24434
$ git checkout pull/24434

Update a local copy of the PR:
$ git checkout pull/24434
$ git pull https://git.openjdk.org/jdk.git pull/24434/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24434

View PR using the GUI difftool:
$ git pr show -t 24434

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24434.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353694: Resolved Class/Field/Method CP entries missing from AOT Configuration

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 111 new commits pushed to the master branch:

• 5f2a604: 8353840: JNativeScan should not abort for missing classes
• 1f21da7: 8351462: Improve robustness of String concatenation
• 567c688: 8353597: Refactor handling VM options for AOT cache input and output
• ... and 108 more: https://git.openjdk.org/jdk/compare/57df89c46449a19bb626fee2ea01c868e6dfb712...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (312c5525)

[iklam]

@iwanowww @shipilev could you review? The same code is already in premain branch.

[shipilev]

Sorry, yes, looks reasonable.