8353709: Debug symbols bundle should contain full debug files when building --with-external-symbols-in-bundles=public

[RealCLanger]

Currently, when building with --with-external-symbols-in-bundles=public, the debug symbols bundle contains the stripped pdb files. It should better have the full pdb files since stripped pdbs are in the runtime image already.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353709: Debug symbols bundle should contain full debug files when building --with-external-symbols-in-bundles=public (Bug - P3)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24440/head:pull/24440
$ git checkout pull/24440

Update a local copy of the PR:
$ git checkout pull/24440
$ git pull https://git.openjdk.org/jdk.git pull/24440/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24440

View PR using the GUI difftool:
$ git pr show -t 24440

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24440.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353709: Debug symbols bundle should contain full debug files when building --with-external-symbols-in-bundles=public

Reviewed-by: erikj, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 353e173: 8219408: Tests should handle ${} in the view of jtreg "smart action"
• 26bb183: 8352621: MatchException from backwards incompatible change to switch expressions
• e8c9e5c: 8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently
• 6ab1647: 8353637: ZGC: Discontiguous memory reservation is broken on Windows
• c494a00: 8353559: Restructure CollectedHeap error printing
• 32d6d03: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java
• 39549f8: 8352116: Deadlock with GCLocker and JVMTI after JDK-8192647
• d63b561: 8353188: C1: Clean up x86 backend after 32-bit x86 removal
• d1e91fc: 8353344: RISC-V: Detect and enable several extensions for debug builds
• 6abf4e6: 8353568: SEGV_BNDERR signal code adjust definition
• ... and 21 more: https://git.openjdk.org/jdk/compare/41d4a0d7bdda2a96af1e7f549c05d99d68c040dc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@RealCLanger The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4c316976)

[erikj79]

Is the symbols bundle currently containing just the stripped pdbs, or both the full and the stripped pdbs?

[RealCLanger]

Is the symbols bundle currently containing just the stripped pdbs, or both the full and the stripped pdbs?

Currently the bundle only contains the stripped pdb files.

This is because during preparation of the bundle files we rename the stripped.pdb files over the full pdb files if they are present. See line 130 of Bundles.gmk.

[erikj79]

Is the symbols bundle currently containing just the stripped pdbs, or both the full and the stripped pdbs?

Currently the bundle only contains the stripped pdb files.

This is because during preparation of the bundle files we rename the stripped.pdb files over the full pdb files if they are present. See line 130 of Bundles.gmk.

Thanks for the explanation. Then the patch makes sense to me.

[RealCLanger]

/integrate

[openjdk]

Going to push as commit 60fbf73.
Since your change was applied there have been 35 commits pushed to the master branch:

• 77fff61: 8341095: Possible overflow in os::Posix::print_uptime_info
• 9128ec6: 8352935: Launcher should not add $JDK/../lib to LD_LIBRARY_PATH
• 27c8d9d: 8352686: Opensource JInternalFrame tests - series3
• 66435c2: 8352684: Opensource JInternalFrame tests - series1
• 353e173: 8219408: Tests should handle ${} in the view of jtreg "smart action"
• 26bb183: 8352621: MatchException from backwards incompatible change to switch expressions
• e8c9e5c: 8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently
• 6ab1647: 8353637: ZGC: Discontiguous memory reservation is broken on Windows
• c494a00: 8353559: Restructure CollectedHeap error printing
• 32d6d03: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java
• ... and 25 more: https://git.openjdk.org/jdk/compare/41d4a0d7bdda2a96af1e7f549c05d99d68c040dc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 60fbf73.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.