Skip to content

8358685: [TEST] AOTLoggingTag.java failed with missing log message #25658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Jun 5, 2025

Hi,

Can you help to review this patch?
AOTLoggingTag.java failed with "'[info][aot] Writing binary AOTConfiguration file:' missing from stdout/stderr"
But in fact there is such log, but it looks like "[info ][aot] Writing binary AOTConfiguration file: hello.aotconfig", because there is some [warning] message above it, so there space indent added.

Some warning message above is:
"[warning][aot] Method in original class is missing from regenerated class: 0x00007f14c04653b0 double java.lang.invoke.LambdaForm$Holder.zero_D(java.lang.Object)"

Seems it's enough to just verify [aot] Writing binary AOTConfiguration file: exist in the log, I hope I'm understanding the original intention of this test correctly.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358685: [TEST] AOTLoggingTag.java failed with missing log message (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25658/head:pull/25658
$ git checkout pull/25658

Update a local copy of the PR:
$ git checkout pull/25658
$ git pull https://git.openjdk.org/jdk.git pull/25658/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25658

View PR using the GUI difftool:
$ git pr show -t 25658

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25658.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2025

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 5, 2025

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358685: [TEST] AOTLoggingTag.java failed with missing log message

Reviewed-by: iklam, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jun 5, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2025

Webrevs

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 5, 2025
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@Hamlin-Li
Copy link
Author

Thank you @iklam @shipilev for reviewing.

@Hamlin-Li
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 6, 2025

Going to push as commit 9658cec.
Since your change was applied there have been 56 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 6, 2025
@openjdk openjdk bot closed this Jun 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 6, 2025
@openjdk
Copy link

openjdk bot commented Jun 6, 2025

@Hamlin-Li Pushed as commit 9658cec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the AOTLoggingTag-missing-log branch June 6, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants