Skip to content

8358721: Update JCov for class file version 70 #25665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shurymury
Copy link
Member

@shurymury shurymury commented Jun 5, 2025

JDK-8358721: Update JCov for class file version 70


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358721: Update JCov for class file version 70 (Task - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25665/head:pull/25665
$ git checkout pull/25665

Update a local copy of the PR:
$ git checkout pull/25665
$ git pull https://git.openjdk.org/jdk.git pull/25665/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25665

View PR using the GUI difftool:
$ git pr show -t 25665

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25665.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2025

👋 Welcome back shurailine! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 5, 2025

@shurymury This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358721: Update JCov for class file version 70

Reviewed-by: iris, alanb, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8358721: Update JCov for class file version 70 8358721: Update JCov for class file version 70 Jun 5, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

@shurymury The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jun 5, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 6, 2025
Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that jcov-test target works with this update.

@shurymury
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 6, 2025

Going to push as commit 026975a.
Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 6, 2025
@openjdk openjdk bot closed this Jun 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 6, 2025
@openjdk
Copy link

openjdk bot commented Jun 6, 2025

@shurymury Pushed as commit 026975a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants