8308094: Add a compilation timeout flag to catch long running compilations #26023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
-XX:CompileTaskTimeout
on Linux to limit the amount of time a compilation task can run. The goal of this is initially to be able to find and investigate long-running compilations.The timeout is implemented using a POSIX timer that sends a
SIGALRM
to the compiler thread the compile task is running on. Each compiler thread registers a signal handler that triggers an assert upon receivingSIGALRM
. This is currently only implemented for Linux, because it relies onSIGEV_THREAD_ID
to get the signal delivered to the same thread that timed out.Since
SIGALRM
is now used, the testruntime/signal/TestSigalrm.java
now requiresvm.flagless
so it will not interfere with the compiler thread signal handlers.Testing:
-XX:CompileTaskTimeout=60000
(one minute timeout) to see what fails (compiler/codegen/TestAntiDependenciesHighMemUsage2.java
,compiler/loopopts/TestMaxLoopOptsCountReached.java
, andcompiler/c2/TestScalarReplacementMaxLiveNodes.java
fail)Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26023/head:pull/26023
$ git checkout pull/26023
Update a local copy of the PR:
$ git checkout pull/26023
$ git pull https://git.openjdk.org/jdk.git pull/26023/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26023
View PR using the GUI difftool:
$ git pr show -t 26023
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26023.diff
Using Webrev
Link to Webrev Comment