8361283: [Accessibility,macOS,VoiceOver] VoiceOver announced Tab items of JTabbedPane as RadioButton on macOS #26096
Conversation
|
👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@kumarabhi006 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
| JTabbedPane tabPane = new JTabbedPane(); | ||
| tabPane.setTabLayoutPolicy(JTabbedPane.SCROLL_TAB_LAYOUT); | ||
| tabPane.setTabPlacement(JTabbedPane.TOP); | ||
| for( int i = 0; i < NUM_TABS; ++i) { |
There was a problem hiding this comment.
| for( int i = 0; i < NUM_TABS; ++i) { | |
| for (int i = 0; i < NUM_TABS; ++i) { |
| NSString *value = NSAccessibilityRoleDescription([self accessibilityRole], nil); | ||
| NSString *value = nil; | ||
|
|
||
| if ([[self javaRole] isEqualToString:@"pagetab"]) { |
There was a problem hiding this comment.
Мне кажется было бы лучше просто переопределить:
- (NSString *)accessibilityRoleDescription
В src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/TabButtonAccessibility.m
It seems it would be better to simply override:
- (NSString *)accessibilityRoleDescription
in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/TabButtonAccessibility.m
Issue : VO doesn't announce Tab items of a JTabbedPane as RadioButton which is wrong.
Analysis : That is due to the role mapping of tab items as
NSAccessibilityRadioButtonRoleinJavaAccessibilityUtilities.mfile. Since the accessibility role description is fetched inaccessibilityRoleDescriptionAPI ifCommonComponentAccessiblity.mfile, the sub-role passed as a parameter isnil, returned value is RadioButton..Proposed Fix : Fix is to get the correct accessibility role description from Appkit, we should pass
NSAccessibilityTabButtonSubrolein the subrole parameter and that returns the accessibility role asTaband is announced correctly by VO.Testing : Manual test case has been added to verify the fix.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26096/head:pull/26096$ git checkout pull/26096Update a local copy of the PR:
$ git checkout pull/26096$ git pull https://git.openjdk.org/jdk.git pull/26096/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26096View PR using the GUI difftool:
$ git pr show -t 26096Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26096.diff
Using Webrev
Link to Webrev Comment