Skip to content

8358768: [vectorapi] Make VectorOperators.SUADD an Associative #26099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

igraves
Copy link
Member

@igraves igraves commented Jul 2, 2025

Adding SUADD an associative operation in the Vector API. Saturated addition on fixed-width unsigned integers is provably associative.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358768: [vectorapi] Make VectorOperators.SUADD an Associative (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26099/head:pull/26099
$ git checkout pull/26099

Update a local copy of the PR:
$ git checkout pull/26099
$ git pull https://git.openjdk.org/jdk.git pull/26099/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26099

View PR using the GUI difftool:
$ git pr show -t 26099

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26099.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 2, 2025

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 2, 2025
@openjdk
Copy link

openjdk bot commented Jul 2, 2025

@igraves To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@igraves
Copy link
Member Author

igraves commented Jul 2, 2025

/label core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 2, 2025
@openjdk
Copy link

openjdk bot commented Jul 2, 2025

@igraves
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 2, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant