Skip to content

8361338: JFR: Min and max time in MethodTime event is confusing #26112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Jul 3, 2025

Could I have a review of change that make the method timing event less confusing.

Testing: jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361338: JFR: Min and max time in MethodTime event is confusing (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26112/head:pull/26112
$ git checkout pull/26112

Update a local copy of the PR:
$ git checkout pull/26112
$ git pull https://git.openjdk.org/jdk.git pull/26112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26112

View PR using the GUI difftool:
$ git pr show -t 26112

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26112.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 3, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 3, 2025

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361338: JFR: Min and max time in MethodTime event is confusing

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8361338 JFR: Min and max time in MethodTime event confusing 8361338: JFR: Min and max time in MethodTime event confusing Jul 3, 2025
@openjdk
Copy link

openjdk bot commented Jul 3, 2025

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jul 3, 2025
@egahlin egahlin changed the title 8361338: JFR: Min and max time in MethodTime event confusing 8361338: JFR: Min and max time in MethodTime event is confusing Jul 3, 2025
@egahlin egahlin marked this pull request as ready for review July 4, 2025 10:51
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 4, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 4, 2025
@egahlin
Copy link
Member Author

egahlin commented Jul 6, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 6, 2025

Going to push as commit f3e0588.
Since your change was applied there have been 68 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 6, 2025
@openjdk openjdk bot closed this Jul 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 6, 2025
@openjdk
Copy link

openjdk bot commented Jul 6, 2025

@egahlin Pushed as commit f3e0588.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@egahlin
Copy link
Member Author

egahlin commented Jul 6, 2025

/backport :jdk25

@openjdk
Copy link

openjdk bot commented Jul 6, 2025

@egahlin the backport was successfully created on the branch backport-egahlin-f3e0588d-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit f3e0588d from the openjdk/jdk repository.

The commit being backported was authored by Erik Gahlin on 6 Jul 2025 and was reviewed by Markus Grönlund.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-egahlin-f3e0588d-jdk25:backport-egahlin-f3e0588d-jdk25
$ git checkout backport-egahlin-f3e0588d-jdk25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-egahlin-f3e0588d-jdk25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants