8361103: java_lang_Thread::async_get_stack_trace does not properly protect JavaThread #26119
Conversation
|
👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
|
@alexmenkov The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
| thread = java_lang_Thread::thread(carrier_thread); | ||
| } else { | ||
| thread = java_lang_Thread::thread(java_thread); | ||
| java_thread = java_lang_Thread::thread(carrier_thread); |
There was a problem hiding this comment.
Won't java_thread already have been set correctly by cv_internal_thread_to_JavaThread?
| } | ||
| if (thread == nullptr) { | ||
| if (java_thread == nullptr) { | ||
| // terminated platform thread or unmounted virtual thread |
There was a problem hiding this comment.
Wasn't the unmounted virtual thread case already handled by the return at line 1894?
The fix updates
java_lang_Thread::async_get_stack_trace()(used byjava.lang.Thread.getStackTrace()to get stack trace for platform and mounted virtual threads) to correctly useThreadListHandlefor thread protection.Testing: tier1..5
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26119/head:pull/26119$ git checkout pull/26119Update a local copy of the PR:
$ git checkout pull/26119$ git pull https://git.openjdk.org/jdk.git pull/26119/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26119View PR using the GUI difftool:
$ git pr show -t 26119Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26119.diff
Using Webrev
Link to Webrev Comment