8278874: tighten VerifyStack constraints #26121
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VerifyStack logic in Deoptimization::unpack_frames() attempts to check the expression stack size of the interpreter frame against what GenerateOopMap computes. To do this, it needs to know if the state at the current bci represents the "before" state, meaning the bytecode will be reexecuted, or the "after" state, meaning we will advance to the next bytecode. The old code didn't know how to determine exactly what state we were in, so it checked both. This PR cleans that up, so we only have to compute the oopmap once. It also removes old SPARC support.
Progress
Warning
8278874: tighten VerifyStack constraints
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26121/head:pull/26121
$ git checkout pull/26121
Update a local copy of the PR:
$ git checkout pull/26121
$ git pull https://git.openjdk.org/jdk.git pull/26121/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26121
View PR using the GUI difftool:
$ git pr show -t 26121
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26121.diff
Using Webrev
Link to Webrev Comment