8361140: Missing OptimizePtrCompare check in ConnectionGraph::reduce_phi_on_cmp #26125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…phi_on_cmp When running with `-XX:-OptimizePtrCompare` (which disables pointer comparison optimization), the compiler may hit an assertion failure in debug builds because `optimize_ptr_compare` is still being called. This violates the intended usage of the flag and leads to unexpected crashes. This patch adds an early return to `reduce_phi_on_cmp` when `OptimizePtrCompare` is false. Since the optimization relies on `optimize_ptr_compare` for static reasoning about comparisons, there's no benefit in proceeding with `reduce_phi_on_cmp` when this support is disabled.
|
👋 Welcome back hgqxjj! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with
-XX:-OptimizePtrCompare(which disables pointer comparison optimization), the compiler may hit an assertion failure in debug builds becauseoptimize_ptr_compareis still being called. This violates the intended usage of the flag and leads to unexpected crashes.This patch adds an early return to
reduce_phi_on_cmpwhenOptimizePtrCompareis false. Since the optimization relies onoptimize_ptr_comparefor static reasoning about comparisons, there's no benefit in proceeding withreduce_phi_on_cmpwhen this flag is disabled.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26125/head:pull/26125$ git checkout pull/26125Update a local copy of the PR:
$ git checkout pull/26125$ git pull https://git.openjdk.org/jdk.git pull/26125/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26125View PR using the GUI difftool:
$ git pr show -t 26125Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26125.diff
Using Webrev
Link to Webrev Comment