Skip to content

8361175: JFR: Document differences between method sample events #26132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Jul 4, 2025

Could I have a review that clarifies how the method sample events work?

  • Added descriptions to NativeMethodSample, ExecutionSample and CPUTimeSample to clarify what they sample and what they don't sample.
  • Removed the word "Method" from the labels of the CPUTimeSample and "ExecutionSample events for consistency and to avoid overly verbose event labels.
  • Added the word "setting" so that the description of CPUTimeSample reads "throttle setting" instead of just "throttle".
  • Changed the label for the CPUTimeSamplesLost event to "CPU Time Samples Lost", making it easier to associate with "CPU Time Sample" event.
  • Removed the percentage column from the "native-methods" view, as normalization doesn't make sense when mixing executing and waiting samples.

Testing: tets/jdk/jdk/jfr + tier1

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361175: JFR: Document differences between method sample events (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26132/head:pull/26132
$ git checkout pull/26132

Update a local copy of the PR:
$ git checkout pull/26132
$ git pull https://git.openjdk.org/jdk.git pull/26132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26132

View PR using the GUI difftool:
$ git pr show -t 26132

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26132.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jul 4, 2025

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jul 4, 2025
@egahlin egahlin marked this pull request as ready for review July 4, 2025 18:52
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 4, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant