Skip to content

feat(range): implement component #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2025
Merged

feat(range): implement component #798

merged 3 commits into from
Jun 6, 2025

Conversation

dpellier
Copy link
Contributor

@dpellier dpellier commented Jun 2, 2025

  • new range component
  • bump ark to 5.11.0
  • update form-field with labelId

@dpellier dpellier requested a review from a team as a code owner June 2, 2025 14:27
@var-poro
Copy link
Contributor

var-poro commented Jun 4, 2025 •
edited
Loading

Using ⌘ + ← or ⌘ + → allows the user to select decimal values, even when steps are set.
That leads to 0.1 values that the integrator probably doesn't want.

var-poro
var-poro requested changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@var-poro var-poro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking on filled track adds unloseable focus

@dpellier dpellier requested a review from var-poro June 5, 2025 12:40
@dpellier dpellier merged commit 28efc02 into ods-react Jun 6, 2025
8 of 10 checks passed
@dpellier dpellier deleted the ods-react-range branch June 6, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astagnol astagnol

@var-poro var-poro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpellier @var-poro @astagnol