Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(poc): Add Event Recording in Dry Run Flow to Improve XCM Debugging #7927

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

raymondkfcheung
Copy link
Contributor

@raymondkfcheung raymondkfcheung commented Mar 14, 2025

This PR enhances the XCM dry-run flow by introducing a new storage item to capture emitted events, improving observability during testing and debugging.

Key Changes

  • Added a new EmittedEvent storage to record emitted events during dry-run execution.
  • Ensured events are recorded before post_process to capture intermediate state changes.
  • Integrated event recording in execute_xcm_transfer to persist emitted events for debugging.
  • Verified that recorded events are still available after post_process.

Findings

  • Emitted events were not retained after post_process in the original dry-run flow.
  • With the new storage, events are now correctly recorded before post_process, ensuring they are captured during XCM execution failures or intermediate steps.

@raymondkfcheung raymondkfcheung requested a review from a team as a code owner March 14, 2025 10:26
@raymondkfcheung raymondkfcheung marked this pull request as draft March 14, 2025 10:26
@raymondkfcheung raymondkfcheung changed the title POC on event emission POC on event emission on DryRun Mar 14, 2025
@raymondkfcheung raymondkfcheung changed the title POC on event emission on DryRun (poc): Keep Event Emission on DryRun Mar 14, 2025
@raymondkfcheung raymondkfcheung changed the title (poc): Keep Event Emission on DryRun (poc): Add Event Recording in Dry Run Flow to Improve XCM Debugging Mar 18, 2025
@raymondkfcheung raymondkfcheung added T6-XCM This PR/Issue is related to XCM. T10-tests This PR/Issue is related to tests. labels Mar 18, 2025
@raymondkfcheung raymondkfcheung self-assigned this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T6-XCM This PR/Issue is related to XCM. T10-tests This PR/Issue is related to tests.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant