Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proxy-pallet] Introduce a transfer limit and duration for the AnyWithLimit proxy type #7938

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nathy-bajo
Copy link
Contributor

Attempts to resolve #7564

The fix aims to introduce a transfer limit and duration for the AnyWithLimit proxy type, ensuring that proxies cannot transfer unlimited amounts and that the limit is only valid for a specified duration.

@Nathy-bajo Nathy-bajo requested a review from a team as a code owner March 16, 2025 21:16
@Nathy-bajo Nathy-bajo marked this pull request as draft March 16, 2025 21:17
Copy link
Contributor

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this code can be implemented in the proxy pallet directly.
Firstly, not every chain need (or can have) this feature, and it is not great to bloat them.
Secondly, not every chain have balances pallet (in practice, most do, but that's not a good reason to make it a requirement). And different chains have different ways to perform transfer. It is pointless to hardcoded transfer_allow_death in the pallet as many chains have alternative methods to perform token transfer.

@Nathy-bajo
Copy link
Contributor Author

I don't think this code can be implemented in the proxy pallet directly. Firstly, not every chain need (or can have) this feature, and it is not great to bloat them. Secondly, not every chain have balances pallet (in practice, most do, but that's not a good reason to make it a requirement). And different chains have different ways to perform transfer. It is pointless to hardcoded transfer_allow_death in the pallet as many chains have alternative methods to perform token transfer.

Hmm, can you explain better, please?

@xlc
Copy link
Contributor

xlc commented Mar 16, 2025

which point do you want me to explain more?

also you are not doing any options suggested here #7564 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Balance Transfer - Any Proxy - adding a limit / threshold
2 participants