Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2407] Backport #7843 #7966

Merged
merged 6 commits into from
Mar 20, 2025
Merged

Conversation

paritytech-release-backport-bot[bot]

Backport #7843 into stable2407 from raymondkfcheung.

See the documentation on how to use this bot.

@paritytech-release-backport-bot
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7843-to-stable2407
git worktree add --checkout .worktree/backport-7843-to-stable2407 backport-7843-to-stable2407
cd .worktree/backport-7843-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 21927dd4a5384c7cbb09c8ad0ceac483be787dd1
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Mar 19, 2025
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@raymondkfcheung raymondkfcheung marked this pull request as ready for review March 19, 2025 14:41
@raymondkfcheung raymondkfcheung requested review from a team as code owners March 19, 2025 14:41
Copy link
Contributor

@serban300 serban300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is too big compared with #7843 . Probably some files that didn't exist on this branch have been copied from master . Please check

@raymondkfcheung
Copy link
Contributor

raymondkfcheung commented Mar 19, 2025

The file cumulus/parachains/integration-tests/emulated/tests/people/people-westend/src/tests/governance.rs doesn't exist in the stable2407 release. Shall I delete it from the backport? It is copied from master, resulting in a larger diff compared to #7843. Let me know how you'd like to proceed.

@serban300
Copy link
Contributor

Yes, please delete it

@raymondkfcheung
Copy link
Contributor

Deleted

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8392091

@EgorPopelyaev EgorPopelyaev merged commit 9b18aef into stable2407 Mar 20, 2025
134 of 164 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7843-to-stable2407 branch March 20, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants